Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring AdminCreateCreditMemoForOrderWithCashOnDeliveryTest #31395

Merged
merged 8 commits into from
Mar 7, 2021
Merged

[MFTF] Refactoring AdminCreateCreditMemoForOrderWithCashOnDeliveryTest #31395

merged 8 commits into from
Mar 7, 2021

Conversation

AnnaAPak
Copy link
Contributor

Description (*)

The test is refactored according to the best practices

Manual testing scenarios (*)

  1. Place order through CashOnDelivery payment
  2. Invoice Order
  3. Start creating Credit Memo
  4. Adjust data
  5. Submit Credit Memo
  6. Open created Credit Memo
  7. Make assertions

@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Dec 22, 2020
@rogyar rogyar self-assigned this Jan 20, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Jan 20, 2021
rogyar
rogyar requested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak. Thank you for your collaboration. Please, check my comments below.

...e/Magento/Sales/Test/Mftf/ActionGroup/AdminClickRefundOfflineOnMemoDetailPageActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminClickRefundOfflineOnMemoDetailPageActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use the original CreditMemo entity name. Since just Memo might be confusing (it has many other meanings).

Suggested change
<actionGroup name="AdminClickRefundOfflineOnMemoDetailPageActionGroup">
<actionGroup name="AdminClickRefundOfflineOnCreditMemoDetailPageActionGroup">

Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been refactored.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Jan 20, 2021
@engcom-Hotel engcom-Hotel self-assigned this Jan 21, 2021
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Jan 21, 2021
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Pending Review in High Priority Pull Requests Dashboard Jan 25, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Feb 26, 2021
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8824 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Feb 26, 2021
@engcom-Bravo
Copy link
Contributor

Manual QA not applicable for MFTF Refactoring PR. Moving it to the Extended Testing

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Feb 26, 2021
@engcom-Hotel engcom-Hotel removed their assignment Feb 26, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Feb 26, 2021
@engcom-Hotel engcom-Hotel moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Feb 26, 2021
magento-engcom-team pushed a commit that referenced this pull request Mar 7, 2021
@gabrieldagama
ENGCOM-8824: [MFTF] Refactoring AdminCreateCreditMemoForOrderWithCash…
745cfa6 
…OnDeliveryTest #31395
@magento-engcom-team magento-engcom-team merged commit 0d22124 into magento:2.4-develop Mar 7, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 7, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel left review comments

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Bravo engcom-Bravo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Payment Component: Quote Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AnnaAPak @engcom-Hotel @magento-engcom-team @engcom-Bravo @rogyar @gabrieldagama @sidolov