Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup #31418

Merged
merged 6 commits into from
Jan 23, 2021
Merged

[MFTF] Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup #31418

merged 6 commits into from
Jan 23, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Dec 23, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup #31441: [MFTF] Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Dec 23, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak AnnaAPak changed the title Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup [MFTF] Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup Dec 23, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Dec 23, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 23, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 23, 2020

@magento create issue

@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Dec 23, 2020
@m2-assistant m2-assistant bot mentioned this pull request Dec 23, 2020
Closed
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Dec 23, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8582 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 23, 2020
@sidolov sidolov moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 23, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Dec 23, 2020
@m2-community-project m2-community-project bot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 23, 2020
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel engcom-Hotel moved this from Extended Testing (optional) to To Approve in High Priority Pull Requests Dashboard Dec 24, 2020
gabrieldagama
gabrieldagama suggested changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @engcom-Charlie, please have a look at my comment below, thanks!

app/code/Magento/Checkout/Test/Mftf/Test/OnePageCheckoutWithAllProductTypesTest.xml Outdated Show resolved Hide resolved
@m2-community-project m2-community-project bot moved this from To Approve to Changes Requested in High Priority Pull Requests Dashboard Jan 12, 2021
engcom-Charlie and others added 2 commits January 12, 2021 17:40
@engcom-Charlie @gabrieldagama
change the comment to prevent BIC
cb793f8 
Co-authored-by: Gabriel da Gama <gabriel@gabrielgama.com.br>
@engcom-Charlie
Merge branch '2.4-develop' into add-StorefrontGuestCheckoutProceedToP…
2ee30cb 
…aymentStepActionGroup
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Refactoring for BC
cbc6bea
@engcom-Hotel
Merge remote-tracking branch 'AnnaAPak/add-StorefrontGuestCheckoutPro…
ee97b00 
…ceedToPaymentStepActionGroup' into add-StorefrontGuestCheckoutProceedToPaymentStepActionGroup
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Jan 12, 2021
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Merge in Progress in High Priority Pull Requests Dashboard Jan 13, 2021
magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2021
@gabrieldagama
ENGCOM-8582: [MFTF] Adding StorefrontGuestCheckoutProceedToPaymentSte…
6be78d2 
…pActionGroup #31418
@magento-engcom-team magento-engcom-team merged commit 71e99df into magento:2.4-develop Jan 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 23, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel left review comments

@sidolov sidolov sidolov approved these changes

@gabrieldagama gabrieldagama Awaiting requested review from gabrieldagama

Assignees

@gabrieldagama gabrieldagama

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Component: Customer Component: Downloadable Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding StorefrontGuestCheckoutProceedToPaymentStepActionGroup
7 participants
@AnnaAPak @sidolov @magento-engcom-team @engcom-Hotel @engcom-Alfa @engcom-Charlie @gabrieldagama