Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Updating with AdminOpenCMSPagesGridActionGroup #31569

Merged
merged 3 commits into from
Feb 18, 2021
Merged

[MFTF] Updating with AdminOpenCMSPagesGridActionGroup #31569

merged 3 commits into from
Feb 18, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Jan 6, 2021 •
edited by m2-assistant bot
Loading

Description (*)

Test have been updated with AdminOpenCMSPagesGridActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Updating with AdminOpenCMSPagesGridActionGroup #31573: [MFTF] Updating with AdminOpenCMSPagesGridActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2021

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 6, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 6, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 6, 2021

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 6, 2021
Closed
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 6, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@eduard13 eduard13 self-requested a review January 13, 2021 11:33
@eduard13 eduard13 self-assigned this Jan 13, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Jan 13, 2021
@eduard13
Copy link
Contributor

@magento run all tests

@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 13, 2021
@eduard13
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 15, 2021
@engcom-Foxtrot
Merge branch '2.4-develop-mainline' into upd-with-AdminOpenCMSPagesGr…
c375046 
…idActionGroup

# Conflicts:
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminRequiredFieldsHaveRequiredFieldIndicatorTest.xml
#	app/code/Magento/Cms/Test/Mftf/Test/VerifyTinyMCEv4IsNativeWYSIWYGOnCMSPageTest.xml
#	app/code/Magento/Widget/Test/Mftf/Test/NewProductsListWidgetTest.xml
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

2 similar comments
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

eduard13
eduard13 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests aren't related with these changes.

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Jan 22, 2021
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8682 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 22, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jan 22, 2021
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Jan 22, 2021
@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Jan 26, 2021
magento-engcom-team pushed a commit that referenced this pull request Feb 18, 2021
@gabrieldagama
ENGCOM-8682: [MFTF] Updating with AdminOpenCMSPagesGridActionGroup #3…
73a749e 
…1569
@magento-engcom-team magento-engcom-team merged commit 9b9ee50 into magento:2.4-develop Feb 18, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: Cms Component: Widget Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Updating with AdminOpenCMSPagesGridActionGroup
7 participants
@AnnaAPak @sidolov @eduard13 @engcom-Foxtrot @magento-engcom-team @engcom-Alfa @gabrieldagama