Refactoring StorefrontConfigurableProductBasicInfoTest #31827

kate-kyzyma · 2021-01-25T14:14:00Z

Description (*)

The test is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Run the test in the local environment and verified that it run successfully.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Refactoring StorefrontConfigurableProductBasicInfoTest #31844: Refactoring StorefrontConfigurableProductBasicInfoTest

m2-assistant · 2021-01-25T14:14:03Z

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

kate-kyzyma · 2021-01-25T14:16:05Z

@magento run all tests

eduard13 · 2021-01-26T07:32:03Z

@magento run Semantic Version Checker, Functional Tests EE, Functional Tests CE

eduard13

Hi @kate-kyzyma, thank you for the MFTF improvement. Could you please review the below comments?

eduard13 · 2021-01-26T07:35:07Z

...Test/StorefrontConfigurableProductDetailsTest/StorefrontConfigurableProductBasicInfoTest.xml

-        <see userInput="{{colorProductAttribute1.name}}" selector="{{StorefrontProductInfoMainSection.productAttributeOptions1}}" stepKey="seeInDropDown1"/>
-        <see userInput="{{colorProductAttribute2.name}}" selector="{{StorefrontProductInfoMainSection.productAttributeOptions1}}" stepKey="seeInDropDown2"/>
-        <see userInput="{{colorProductAttribute3.name}}" selector="{{StorefrontProductInfoMainSection.productAttributeOptions1}}" stepKey="seeInDropDown3"/>
+        <actionGroup ref="AssertStorefrontProductStockStatusOnProductPageActionGroup" stepKey="seeProductStatusInStoreFront">


Same here.

Suggested change

<actionGroup ref="AssertStorefrontProductStockStatusOnProductPageActionGroup" stepKey="seeProductStatusInStoreFront">

<actionGroup ref="AssertStorefrontProductStockStatusOnProductPageActionGroup" stepKey="seeProductStockStatus">

Has been renamed

eduard13 · 2021-01-26T07:35:56Z

...Test/StorefrontConfigurableProductDetailsTest/StorefrontConfigurableProductBasicInfoTest.xml

-        <waitForPageLoad stepKey="wait"/>
-        <see userInput="{{_defaultProduct.name}}" selector="{{StorefrontProductInfoMainSection.productName}}" stepKey="seeProductName"/>
-        <see userInput="{{_defaultProduct.sku}}" selector="{{StorefrontProductInfoMainSection.productSku}}" stepKey="seeProductSku"/>
+        <actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openStorefrontProductPage">


We should preserve the step keys to be a backward compatible change.

Suggested change

<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openStorefrontProductPage">

<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="amOnConfigurableProductPage">

Has been renamed

eduard13 · 2021-01-26T07:41:51Z

...eProduct/Test/Mftf/ActionGroup/AssertStorefrontProductAtttributeOptionVisibleActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertStorefrontProductAtttributeOptionVisibleActionGroup">


A typo here. Please rename the file and adjust the test.

Suggested change

<actionGroup name="AssertStorefrontProductAtttributeOptionVisibleActionGroup">

<actionGroup name="AssertStorefrontProductAttributeOptionVisibleActionGroup">

Has been renamed

gabrieldagama · 2021-01-26T17:18:00Z

@magento create issue

…ductBasicInfoTest

engcom-Hotel · 2021-01-27T08:35:09Z

@magento run all tests

engcom-Hotel · 2021-01-27T11:09:32Z

@magento run Functional Tests B2B, Integration Tests, Sample Data Tests B2B, WebAPI Tests

engcom-Hotel · 2021-01-27T13:04:35Z

@magento run Functional Tests B2B

eduard13

Thank you @engcom-Hotel for assistance here.

magento-engcom-team · 2021-01-27T13:50:53Z

Hi @eduard13, thank you for the review.
ENGCOM-8707 has been created to process this Pull Request

engcom-Alfa · 2021-01-27T14:56:06Z

QA not applicable

engcom-Hotel · 2021-01-27T15:58:42Z

@magento run Functional Tests B2B

engcom-Hotel · 2021-01-28T08:04:55Z

@magento run Functional Tests B2B

…31827

m2-assistant · 2021-01-30T17:33:29Z

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

kate-kyzyma added 2 commits January 25, 2021 15:21

- refactoring the test

b4db970

- refactoring the test

09f63c0

magento-engcom-team added Component: ConfigurableProduct Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 25, 2021

kate-kyzyma changed the title ~~Refactoring storefront configurable product basic info test~~ Refactoring StorefrontConfigurableProductBasicInfoTest Jan 25, 2021

m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jan 25, 2021

m2-community-project bot added the Progress: pending review label Jan 25, 2021

eduard13 self-assigned this Jan 26, 2021

eduard13 self-requested a review January 26, 2021 07:29

m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Jan 26, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 26, 2021

eduard13 requested changes Jan 26, 2021

View reviewed changes

m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Jan 26, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 26, 2021

eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 26, 2021

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 26, 2021

m2-assistant bot mentioned this pull request Jan 26, 2021

[Issue] Refactoring StorefrontConfigurableProductBasicInfoTest #31844

Closed

4 tasks

m2-community-project bot added this to Changes Requested in High Priority Pull Requests Dashboard Jan 26, 2021

m2-community-project bot removed this from Changes Requested in Pull Requests Dashboard Jan 26, 2021

engcom-Hotel self-assigned this Jan 27, 2021

refactoring

c74c888

m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Jan 27, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Jan 27, 2021

Merge branch '2.4-develop' into Refactoring-StorefrontConfigurablePro…

4708c00

…ductBasicInfoTest

eduard13 approved these changes Jan 27, 2021

View reviewed changes

m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Jan 27, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Jan 27, 2021

engcom-Alfa self-assigned this Jan 27, 2021

engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jan 27, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 27, 2021

engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Jan 27, 2021

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Jan 27, 2021

engcom-Hotel moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Jan 28, 2021

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jan 28, 2021

magento-engcom-team pushed a commit that referenced this pull request Jan 30, 2021

ENGCOM-8707: Refactoring StorefrontConfigurableProductBasicInfoTest #…

d925e09

…31827

magento-engcom-team merged commit 63e5e8d into magento:2.4-develop Jan 30, 2021

gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Feb 4, 2021

gabrieldagama added the Type: Test Coverage label Mar 2, 2021

magento-engcom-team removed this from Recently Merged in High Priority Pull Requests Dashboard Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring StorefrontConfigurableProductBasicInfoTest #31827

Refactoring StorefrontConfigurableProductBasicInfoTest #31827

kate-kyzyma commented Jan 25, 2021 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Jan 25, 2021

kate-kyzyma commented Jan 25, 2021

eduard13 commented Jan 26, 2021

eduard13 left a comment

eduard13 Jan 26, 2021

engcom-Hotel Jan 27, 2021

eduard13 Jan 26, 2021

engcom-Hotel Jan 27, 2021

eduard13 Jan 26, 2021

engcom-Hotel Jan 27, 2021

gabrieldagama commented Jan 26, 2021

engcom-Hotel commented Jan 27, 2021

engcom-Hotel commented Jan 27, 2021

engcom-Hotel commented Jan 27, 2021

eduard13 left a comment

magento-engcom-team commented Jan 27, 2021

engcom-Alfa commented Jan 27, 2021

engcom-Hotel commented Jan 27, 2021

engcom-Hotel commented Jan 28, 2021

m2-assistant bot commented Jan 30, 2021

	<actionGroup ref="AssertStorefrontProductStockStatusOnProductPageActionGroup" stepKey="seeProductStatusInStoreFront">
	<actionGroup ref="AssertStorefrontProductStockStatusOnProductPageActionGroup" stepKey="seeProductStockStatus">

	<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openStorefrontProductPage">
	<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="amOnConfigurableProductPage">

	<actionGroup name="AssertStorefrontProductAtttributeOptionVisibleActionGroup">
	<actionGroup name="AssertStorefrontProductAttributeOptionVisibleActionGroup">

Refactoring StorefrontConfigurableProductBasicInfoTest #31827

Refactoring StorefrontConfigurableProductBasicInfoTest #31827

Conversation

kate-kyzyma commented Jan 25, 2021 • edited by m2-assistant bot Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Jan 25, 2021

kate-kyzyma commented Jan 25, 2021

eduard13 commented Jan 26, 2021

eduard13 left a comment

Choose a reason for hiding this comment

eduard13 Jan 26, 2021

Choose a reason for hiding this comment

engcom-Hotel Jan 27, 2021

Choose a reason for hiding this comment

eduard13 Jan 26, 2021

Choose a reason for hiding this comment

engcom-Hotel Jan 27, 2021

Choose a reason for hiding this comment

eduard13 Jan 26, 2021

Choose a reason for hiding this comment

engcom-Hotel Jan 27, 2021

Choose a reason for hiding this comment

gabrieldagama commented Jan 26, 2021

engcom-Hotel commented Jan 27, 2021

engcom-Hotel commented Jan 27, 2021

engcom-Hotel commented Jan 27, 2021

eduard13 left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Jan 27, 2021

engcom-Alfa commented Jan 27, 2021

engcom-Hotel commented Jan 27, 2021

engcom-Hotel commented Jan 28, 2021

m2-assistant bot commented Jan 30, 2021

kate-kyzyma commented Jan 25, 2021 •

edited by m2-assistant bot

Loading