New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change description of NewRelic configuration #31944
Change description of NewRelic configuration #31944
Conversation
Hi @nuzil. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento create issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nuzil!
Thanks for your contribution. I think this changes make sense
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Page form text describes according to the new relic's old UI After: ✔️ Page form text describes according to the new relic's new UI Since it is just a text change and has impact on any other functional features, and so no regression test cases required additionally. |
Description (*)
Change description of NewRelic configuration as it is not representing real feature.
Currently extension created own APP for each Area code if this option is enabled.
https://github.com/nuzil/magento2/blob/patch-1/app/code/Magento/NewRelicReporting/Plugin/StatePlugin.php#L58
Contribution checklist (*)
Resolved issues: