Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change description of NewRelic configuration #31944

Merged
merged 2 commits into from Jun 11, 2022

Conversation

nuzil
Copy link
Contributor

@nuzil nuzil commented Feb 2, 2021

Description (*)

Change description of NewRelic configuration as it is not representing real feature.

Currently extension created own APP for each Area code if this option is enabled.

https://github.com/nuzil/magento2/blob/patch-1/app/code/Magento/NewRelicReporting/Plugin/StatePlugin.php#L58

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Change description of NewRelic configuration  #31947: Change description of NewRelic configuration

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2021

Hi @nuzil. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@nuzil
Copy link
Contributor Author

nuzil commented Feb 2, 2021

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento create issue

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Feb 2, 2021
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Feb 2, 2021
@Den4ik Den4ik self-assigned this May 3, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard May 3, 2021
@Den4ik Den4ik added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Progress: pending review and removed Progress: review labels May 3, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Pending Review in Pull Requests Dashboard May 3, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard May 3, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard May 3, 2021
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nuzil!
Thanks for your contribution. I think this changes make sense

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard May 3, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Feb 16, 2022
@engcom-Alfa engcom-Alfa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 16, 2022
@m2-community-project m2-community-project bot removed this from Testing in Progress in Pull Requests Dashboard Feb 16, 2022
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 16, 2022
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have Magento latest instance installed

Manual testing scenario:

  1. Navigate to Admin>Store>Configuration>General>New Relic Reporting

  2. Validate the text content of the form

Before: ✖️ Page form text describes according to the new relic's old UI

image

After: ✔️ Page form text describes according to the new relic's new UI

image

Since it is just a text change and has impact on any other functional features, and so no regression test cases required additionally.

@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Feb 16, 2022
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Feb 16, 2022
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Feb 17, 2022
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 18, 2022
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Feb 18, 2022
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit a70c62e into magento:2.4-develop Jun 11, 2022
@ishakhsuvarov ishakhsuvarov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: NewRelicReporting Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Change description of NewRelic configuration
7 participants