Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Annotation for Magento\Framework\App\CacheInterface::load #31987

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

Incorrect Annotation for Magento\Framework\App\CacheInterface::load #31987

wants to merge 5 commits into from
+6 −4

Conversation

bluemwhitew
Copy link
Contributor

Description (*)

Amended an annotation that was causing issues with CI tooling, such as Scrutinizer CI.

Fixed Issues

  1. Fixes Magento\Framework\App\CacheInterface::load annotation is wrong #31450

Related Pull Requests

N/A

Manual Testing Scenarios (*)

N/A

Questions or Comments

N/A

Contribution Checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bluemwhitew
magento#31450: Incorrect Annotation for `Magento\Framework\App\CacheI…
d168ed2 
…nterface::load`

- Amending Annotation
- Improving Readability
@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2021

Hi @bluemwhitew. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Feb 8, 2021
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Feb 8, 2021
@bluemwhitew
Copy link
Contributor Author

@magento run Semantic Version Checker

@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Feb 23, 2021
ihor-sviziev
ihor-sviziev requested changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add php declare strict_types declare(strict_types=1); at the top file?

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Mar 5, 2021
@bluemwhitew
magento#31450: Incorrect Annotation for `Magento\Framework\App\CacheI…
b4af7fe 
…nterface::load`

- Code Review Feedback/Amends
@m2-community-project m2-community-project bot moved this from Changes Requested to Pending Review in Pull Requests Dashboard Mar 9, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Mar 10, 2021 •
edited
Loading

CC: @kandy @paliarush @sivaschenko @vzabaznov May need your guys help for verify

@mrtuvn mrtuvn removed their assignment Mar 10, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Changes Requested in Pull Requests Dashboard Mar 10, 2021
@engcom-Charlie engcom-Charlie moved this from To Approve to Pending Approval in High Priority Pull Requests Dashboard Nov 7, 2022
@ishakhsuvarov ishakhsuvarov removed this from Pending Approval in High Priority Pull Requests Dashboard Dec 14, 2022
@ishakhsuvarov ishakhsuvarov added this to Pending Review in Pull Requests Dashboard via automation Dec 14, 2022
@ishakhsuvarov ishakhsuvarov moved this from Pending Review to Pending Approval in Pull Requests Dashboard Dec 14, 2022
@bluemwhitew
Copy link
Contributor Author

Bump.

@m2-community-project m2-community-project bot moved this from Pending Approval to Ready for Testing in Pull Requests Dashboard Feb 9, 2023
@RaghavendraTirumalasetti
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@RaghavendraTirumalasetti
Copy link
Contributor

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@RaghavendraTirumalasetti
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@RaghavendraTirumalasetti
Copy link
Contributor

Moving this PR to Pending Approval as per this comment.

Thank you!

@engcom-Delta engcom-Delta moved this from Ready for Testing to Pending Approval in Pull Requests Dashboard Feb 14, 2023
@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@mrtuvn mrtuvn mrtuvn approved these changes

@gabrieldagama gabrieldagama gabrieldagama approved these changes

@andrewbess andrewbess andrewbess approved these changes

@orlangur orlangur Awaiting requested review from orlangur

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

@mrtuvn mrtuvn

@gabrieldagama gabrieldagama

@andrewbess andrewbess

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

@engcom-Lima engcom-Lima

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: App Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending approval Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Pending Approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Magento\Framework\App\CacheInterface::load annotation is wrong