Removed unused plugin on protected method

[erfanimani]

Description (*)

Removed an unused plugin. The plugin seems to be legacy code, and wouldn't have worked anyway do to it being targeted for a protected method.

The plugin even had unit tests.

Actually, the original methods don't seem to be used anywhere either. I'm not sure why they're not removed. They're marked as protected, so it shouldn't cause any backwards compatibility issues.

• isCityActive
• isStateActive

See this commit for some background:
e7f8000

The previous class with different name was renamed and refactored. The methods used to be public. If this hasn't caused any regression (I don't thinks so), then the original methods should be removed too.

Questions or comments

Should the original methods be removed?

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Removed unused plugin on protected method #37927: Removed unused plugin on protected method

[m2-assistant]

Hi @erfanimani. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[BarnyShergold]

@magento run all tests

[magento-engcom-team]

Hi @BarnyShergold, thank you for the review.
ENGCOM-8761 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[BarnyShergold]

@magento run Functional Tests B2B

[BarnyShergold]

@magento run Functional Tests B2B

[BarnyShergold]

@magento run Functional Tests B2B

[BarnyShergold]

@erfanimani The Functional Tests b2B keep failing but I can't see why what you've added would cause these issues - this maybe a false positive. Can you check?

[erfanimani]

Thanks for the heads up @BarnyShergold.

I had a look at the Allure output of the functional tests, and the errors definitely seem unrelated. It looks like these might be changes introduced in 2.4-develop from other PRs?

[BarnyShergold]

@engcom-Hotel Can you advise?

[BarnyShergold]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento create issue

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Integration Tests,Functional Tests EE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

Thanks for the contribution!

✔️ QA Passed

QA not required.

As in this PR, the changes are related to removed unused plugin on protected method
There is nothing to reproduce in this issue but it is a good to have.

Build are failing hence moving it to Extended Testing

[engcom-Echo]

Functional Tests B2B failure are different on last two run on same commit.
Run1

Run2

Hence moving it to Merge In Progress