Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test to correct folder #32299

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Move test to correct folder #32299

merged 1 commit into from
Mar 7, 2021

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Feb 26, 2021 •
edited by m2-assistant bot
Loading

Description (*)

Test was added to wrong directory in e1aaf74#diff-30a77b243d5ff1daa6ffb8334d475e0b01771e9422dfcea29de3ee62863f8911
image

My PR moves it back to the correct folder.
/CC @bubasuma

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Move test to correct folder #32313: Move test to correct folder

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2021

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Feb 26, 2021
@bubasuma
Copy link
Contributor

@ihor-sviziev thanks for this fix.

@Stepa4man Stepa4man self-requested a review February 26, 2021 23:26
@Stepa4man Stepa4man self-assigned this Feb 26, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Feb 26, 2021
@Stepa4man
Copy link
Contributor

@gabrieldagama Can you take a look at failed static test?
It somehow checks the dependencies of classes and modules that weren't changed.

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Feb 26, 2021
@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-8829 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Stepa4man Stepa4man added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 27, 2021
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests B2B, Functional Tests EE, Static Tests

@gabrieldagama gabrieldagama added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Mar 1, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Mar 1, 2021
@gabrieldagama
Copy link
Contributor

Hi @Stepa4man @ihor-sviziev, the static test failure is not related to the PR changes, that is failing constantly on all branches, an internal team has merged it and it is a false-positive, they are working on fixing it.

@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 1, 2021
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8829 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Mar 1, 2021
@engcom-Bravo
Copy link
Contributor

Manual QA is not applicable. Moving the PR to Extended Testing column

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Mar 1, 2021
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE, Static Tests

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests EE

1 similar comment
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests EE

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Mar 3, 2021
@magento-engcom-team magento-engcom-team merged commit 2f0b2b1 into magento:2.4-develop Mar 7, 2021
magento-engcom-team pushed a commit that referenced this pull request Mar 7, 2021
@gabrieldagama
ENGCOM-8829: Move test to correct folder #32299
3b35249
@m2-assistant
Copy link

m2-assistant bot commented Mar 7, 2021

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama approved these changes

@Stepa4man Stepa4man Stepa4man approved these changes

Assignees

@gabrieldagama gabrieldagama

@Stepa4man Stepa4man

@engcom-Bravo engcom-Bravo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4 Type: Code Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Move test to correct folder
6 participants
@ihor-sviziev @bubasuma @Stepa4man @magento-engcom-team @gabrieldagama @engcom-Bravo