[32279][GraphQL] Fixed issue with tier price

[Usik2203]

Description (*)

This PR fixes issue #32279
(Confirmed issue case #32279 (comment))

Preconditions

Tier price was added for product with name
banana and banana-1

BEFORE:

AFTER:

Fixed Issues (if relevant)

1. Fixes Graphql price tiers returning data from previous item in foreach #32279

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Usik2203]

@magento run all tests

[eduard13]

Hi @Usik2203, could you please review the comments below?

Thank you.

[eduard13]

Why not simply cleaning the formatAndFilterTierPrices? Any concerns about that?

Suggested change

	$this->resetFormatAndFilterTierPrices();
	$this->formatAndFilterTierPrices = [];

[Usik2203]

Hi @eduard13
Unfortunately this approach isn't working in this case
We are losing some data
We will get tier price only for first item in this case
Example:

But actually banana-1 product has tier price

[eduard13]

But, I think you do the same in resetFormatAndFilterTierPrices below, cleaning the formatAndFilterTierPrices. Am I wrong?

[Usik2203]

Hi @eduard13
Yes you are right. It was my mistake 🤦
Fixed this one
Thanks!

[eduard13]

Most probably we'll have to improve the test coverage, by having at least 1 product without tierPrices, in order to make sure it doesn't return anything.

[Usik2203]

**DONE **
Added one product without tier price.

[SirCoolness]

@magento give me test instance

[Usik2203]

@magento run all tests

[eduard13]

@magento run Functional Tests EE

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-8985 has been created to process this Pull Request

[dmitriyprime]

✔️ QA passed

❌ Before
{
"data": {
"products": {
"items": [
{
"id": 2,
"price_tiers": [
{
"quantity": 3,
"final_price": {
"value": 140
}
},
{
"quantity": 5,
"final_price": {
"value": 130
}
}
]
},
{
"id": 1,
"price_tiers": [
{
"quantity": 5,
"final_price": {
"value": 130
}
},
{
"quantity": 5,
"final_price": {
"value": 90
}
},
{
"quantity": 10,
"final_price": {
"value": 80
}
}
]
},
{
"id": 6,
"price_tiers": [
{
"quantity": 5,
"final_price": {
"value": 130
}
},
{
"quantity": 5,
"final_price": {
"value": 90
}
},
{
"quantity": 10,
"final_price": {
"value": 80
}
}
]
},
{
"id": 5,
"price_tiers": [
{
"quantity": 5,
"final_price": {
"value": 130
}
},
{
"quantity": 5,
"final_price": {
"value": 90
}
},
{
"quantity": 10,
"final_price": {
"value": 80
}
}
]
},
{
"id": 4,
"price_tiers": [
{
"quantity": 5,
"final_price": {
"value": 130
}
},
{
"quantity": 5,
"final_price": {
"value": 90
}
},
{
"quantity": 10,
"final_price": {
"value": 80
}
}
]
},
{
"id": 3,
"price_tiers": [
{
"quantity": 5,
"final_price": {
"value": 130
}
},
{
"quantity": 5,
"final_price": {
"value": 90
}
},
{
"quantity": 10,
"final_price": {
"value": 80
}
}
]
}
]
}
}
}

✔️ After:
{
"data": {
"products": {
"items": [
{
"id": 2,
"price_tiers": [
{
"quantity": 3,
"final_price": {
"value": 140
}
},
{
"quantity": 5,
"final_price": {
"value": 130
}
}
]
},
{
"id": 1,
"price_tiers": [
{
"quantity": 5,
"final_price": {
"value": 90
}
},
{
"quantity": 10,
"final_price": {
"value": 80
}
}
]
},
{
"id": 6,
"price_tiers": []
},
{
"id": 5,
"price_tiers": []
},
{
"id": 4,
"price_tiers": []
},
{
"id": 3,
"price_tiers": []
}
]
}
}
}

[m2-assistant]

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.