Shipping radio button reorder#30257

[gixid192]

Description (*)

In Admin, in reorder page, click the link/button Click to change shipping method doesn't show radio buttons to select shipping methods.

Fixed Issues (if relevant)

Fixes #30257

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @gixid192. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[gixid192]

@magento run all tests

[gixid192]

@magento run Functional Tests EE, Functional Tests B2B

[eduard13]

@magento give me test instance

[magento-deployment-service]

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @eduard13, here is your Magento Instance: https://823220511602131577cfb1ce5e63c209.instances.magento-community.engineering
Admin access: https://823220511602131577cfb1ce5e63c209.instances.magento-community.engineering/admin_55ff
Login: 334d1b65
Password: 4914d987ee1a

[gixid192]

Hi @eduard13
The Functional Tests B2B failed but the error is from frontend, what I changed is in admin. Could you help take a look at this too?

[eduard13]

@magento run Functional Tests B2B

[eduard13]

Hi @gixid192, thank you for your contribution. Due to Magento Definition of Done all new changes should be covered by tests, so could you also provide a MFTF test coverage for the provided fix?

Thank you.

[gixid192]

Hi @eduard13
The root cause of this issue is the positions of the radio and label are different from the CSS.

I just move the code around to meet the requirement. This is core Magento code, I didn't add any new code. So I think it already has tests covered?

[eduard13]

Thank you for clarifying it. Let's wait for Functional Tests B2B results.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-8908 has been created to process this Pull Request

[magento-engcom-team]

@gixid192 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Oscar]

✔️ QA passed

Was checked case by next steps from Manual testing scenarios:
Preconditions:

• Magento EE 2.4.0, EE 2.4.1-alpha4, EE 2.4.2-beta1 is installed, should be actual for CE
• A Customer account with shipping address and a billing address is created
• A Simple Product is created
• Several delivery methods are configured
• At least one order is created

Steps to Reproduce:

• Go to Magento Admin panel > Sales > Orders
• Select the created order
• Click the “View” link
• Click the “Reorder” button
• Scroll down the page to the “Payment & Shipping Information” section
• Click the “Click to change shipping method”

❌ Before:
The list of delivery methods appears without radio buttons

✔️ After:
The list of delivery methods appears with radio buttons

[m2-assistant]

Hi @gixid192, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.