-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WEBP + AVIF Support by default #32400
Add WEBP + AVIF Support by default #32400
Conversation
Hi @in-session. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @in-session,
Could you sign Adobe CLA and update the nginx config sample as well?
https://github.com/magento/magento2/blob/2.4-develop/nginx.conf.sample
Maybe add the new avif image format as well? It's not supported by many browsers yet, but will be in the future ... Some extension developers are already starting to implement it: |
Yeah, make sense for sure
…On Tue, 9 Mar 2021 at 13:30, Pieter Hoste ***@***.***> wrote:
Maybe add the new avif image format as well? It's not supported by many
browsers yet <https://caniuse.com/avif>, but will be in the future ...
Some extension developers are already starting to implement it:
- https://www.yireo.com/blog/2020-12-29-magento2-webp-becomes-next-gen
-
https://www.jajuma.de/en/jajuma-develop/extensions/ultimate-image-optimizer-extension-for-magento-2
- ...
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#32400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOJOUPSC3FMNIV6FVXL67DTCYBETANCNFSM4Y3JOOMA>
.
|
@magento run all tests |
Maybe also avif sequences? h5bp/server-configs-apache#251 https://github.com/h5bp/server-configs-apache/ is my go to project for verifying apache config settings, maybe double check webp as well? (sorry lack of time here for proper review) |
Ok let me check i will add also some other like opentype fonts |
Have you some information about nginx? or
|
@in-session I believe it's better to use |
QA passed |
@magento create issue |
@magento run all tests |
Hi @in-session, thank you for your contribution! |
Webp should already be set up by default
Steps to reproduce:
Resolved issues: