Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WEBP + AVIF Support by default #32400

Merged
merged 29 commits into from
Apr 11, 2021

Conversation

in-session
Copy link
Contributor

@in-session in-session commented Mar 9, 2021

Webp should already be set up by default

Steps to reproduce:

  1. Add webp, avif, etc files to lib/web/images directory.
  2. Modify app/code/Magento/Backend/view/adminhtml/layout/admin_login.xml file to use webp, avif, etc file as Magento 2 logo (edit "logo" block "logo_image_src" argument value).
  3. Flush cache.
  4. Check webp, avif, etc file is used as Magento 2 logo on the admin login page.

Resolved issues:

  1. resolves [Issue] Add WEBP + AVIF Support by default #32495: Add WEBP + AVIF Support by default

@m2-assistant
Copy link

m2-assistant bot commented Mar 9, 2021

Hi @in-session. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @in-session,
Could you sign Adobe CLA and update the nginx config sample as well?
https://github.com/magento/magento2/blob/2.4-develop/nginx.conf.sample

@m2-community-project m2-community-project bot added this to Changes Requested in Pull Requests Dashboard Mar 9, 2021
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Mar 9, 2021
@hostep
Copy link
Contributor

hostep commented Mar 9, 2021

Maybe add the new avif image format as well? It's not supported by many browsers yet, but will be in the future ...

Some extension developers are already starting to implement it:

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Mar 9, 2021 via email

@in-session in-session changed the title Add WEBP Support by default Add WEBP + AVIF Support by default Mar 9, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@hostep
Copy link
Contributor

hostep commented Mar 9, 2021

Maybe also avif sequences? h5bp/server-configs-apache#251

https://github.com/h5bp/server-configs-apache/ is my go to project for verifying apache config settings, maybe double check webp as well? (sorry lack of time here for proper review)

@in-session
Copy link
Contributor Author

Ok let me check i will add also some other like opentype fonts

@in-session
Copy link
Contributor Author

Maybe also avif sequences? h5bp/server-configs-apache#251

https://github.com/h5bp/server-configs-apache/ is my go to project for verifying apache config settings, maybe double check webp as well? (sorry lack of time here for proper review)

Have you some information about nginx?
location ~* \.(ico|jpg|jpeg|png|gif|svg|webp|avif|avifs

or

location ~* \.(ico|jpg|jpeg|png|gif|svg|webp|avif|avifs?

@ihor-sviziev
Copy link
Contributor

@in-session I believe it's better to use location ~* \.(ico|jpg|jpeg|png|gif|svg|webp|avif|avifs as it will be just simpler to read

@engcom-Foxtrot
Copy link
Contributor

QA passed

@engcom-Foxtrot engcom-Foxtrot added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Mar 16, 2021
@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Mar 16, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Mar 16, 2021
@engcom-Oscar
Copy link

@magento create issue

@engcom-Oscar engcom-Oscar added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Mar 16, 2021
@engcom-Oscar engcom-Oscar moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Mar 16, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Mar 16, 2021
@m2-community-project m2-community-project bot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Mar 16, 2021
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Mar 22, 2021
@magento-engcom-team magento-engcom-team merged commit 91f3c7a into magento:2.4-develop Apr 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2021

Hi @in-session, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add WEBP + AVIF Support by default
8 participants