Use tested $fileName in exception message for consistency

[chris-pook]

Description

This is a fix for #32446. The adapter does not necessarily have $this->_fileName set in the scenario where $filename doesn't exist. In this case the logged exception has an empty filename. For consistency it is best to use the $filename param value here as that is the one that was tested to exist and has the correct value.

Fixed Issues (if relevant)

1. Fixes Image filename not necessarily set when logging file not found error #32446

Manual testing scenarios (*)

1. In extension code use \Magento\Framework\Image\Factory::create($filePath) where $filePath is not a valid file.
2. View var/log/exception.log

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @chris-pook. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Den4ik]

@magento run all tests

[Den4ik]

@magento run Functional Tests B2B, Integration Tests

[chris-pook]

@magento run Functional Tests B2B

[Den4ik]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

Hi @chris-pook Thanks for your contribution
Failed B2B test is not related to changes in this PR

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-9055 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[Den4ik]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Delta]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenario:

1.In extension code use \Magento\Framework\Image\Factory::create($filePath) where $filePath is not a valid file.
2.Create main.ERROR: File "" does not exist exception.
3.View magento root/var/log/exception.log

Before: ✖️ 

After: ✔️  

Builds are failed. Hence, moving this PR to Extended Testing.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run Functional Tests EE,Functional Tests B2B,Functional Tests CE,Integration Tests

[engcom-Echo]

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B

[engcom-Echo]

Failing functional test are not related to PR changes.
Hence moving it to merge in progress

[engcom-Charlie]

@engcom-Echo please add supporting information about build failures. Moving it to Extended Testing.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run Functional Tests B2B ,Functional Tests EE, Functional Tests CE,Integration Tests ,WebAPI Tests

[engcom-Echo]

Functional Tests B2B,Functional Tests CE,Functional Tests EE failure are known and remaining different on last two run on same commit.
Known Failure:

ACQE-3807 - AdminAdobeStockImagePreviewSameSeriesSeeMoreTest
ACQE-6450 - AdminAdobeStockImagePreviewSameModelSeeMoreTestz
ACQE-6018 - AdminCreateShipmentWithBundleAndSimpleProductsSingleStockModeTest
ACQE-5677 - StorefrontQuoteCanBeRenamedUntilLockedTest
ACQE-6438 - StorefrontPropertiesOfAProductAttributeTest
ACQE-6454 - AdminSeeMoreFromSeriesTest
ACQE-6349 - AdminContentHierarchyDisabledScopeWebsiteFilterTest
ACQE-6438 - StorefrontPropertiesOfAProductAttributeTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

Functional Tests B2B
Run1

Run2

Functional Tests CE
Run1

Run2

Functional Tests EE
Run1

Run2

WebAPI Tests

Integration Tests

Hence moving it to merge in progress