Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing trailing semicolon for theme blank #32457

Draft
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Draft

Fix missing trailing semicolon for theme blank #32457

wants to merge 1 commit into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Mar 12, 2021 •
edited

Description (*)

Clean up missing parts in theme blank + reduce double padding spaces in layout 2columns-left between sidebar and main

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

CC: @ptylek can you help review this

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix missing trailing semicolon for theme blank #32508: Fix missing trailing semicolon for theme blank

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn
mrtuvn commented Mar 12, 2021
View reviewed changes
app/design/frontend/Magento/blank/Magento_Sales/web/css/source/_email.less
&:extend(.no-link a);
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid duplication. Migrate 2 parts seperate into one define

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Mar 12, 2021
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 13, 2021

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 13, 2021

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 13, 2021

@magento run Functional Tests B2B, Functional Tests CE

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 16, 2021
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 16, 2021
Open
4 tasks
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 23, 2021

@magento run Functional Tests B2B

1 similar comment
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 23, 2021

@magento run Functional Tests B2B

@mrtuvn mrtuvn force-pushed the fix-missing-trailing-semicolon-in-less-theme-blank branch from 491f82d to 5406d0b Compare March 26, 2021 07:24
mrtuvn
mrtuvn commented Mar 26, 2021
View reviewed changes
app/design/frontend/Magento/blank/web/css/source/_layout.less
.sidebar-additional {
clear: left;
float: left;
padding-left: 0;
padding-right: @layout-column__additional-sidebar-offset;
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce double padding spaces ! Previously magento accidentally add spaces from both main and sidebar

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 26, 2021

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 27, 2021

@magento run Functional Tests B2B

@mrtuvn mrtuvn added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 21, 2021
@mrtuvn mrtuvn marked this pull request as draft March 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Release Line: 2.4 Risk: low
Projects
Pull Requests Dashboard
  
Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix missing trailing semicolon for theme blank
3 participants
@mrtuvn @gabrieldagama @magento-engcom-team