[MFTF] Added AdminStartupPageTest and AssertAdminPageTitleActionGroup #32771

Usik2203 · 2021-04-16T10:59:45Z

Description (*)

This AdminStartupPageTest checks if Startup Page functionality works after login .

set Orders Startup Page in config
Login to admin

Also was represented newAssertAdminPageTitleActionGroup

m2-assistant · 2021-04-16T10:59:47Z

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Usik2203 · 2021-04-29T12:14:10Z

@magento run all tests

magento-automated-testing · 2021-04-29T12:14:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13

Thank you @Usik2203 for the improvements. Could you please the minor suggestion below?
Thank you.

eduard13 · 2021-06-02T06:43:36Z

app/code/Magento/Sales/Test/Mftf/Test/EndToEndB2CAdminTest.xml

@@ -92,7 +92,9 @@
        <closeAdminNotification stepKey="closeAdminNotificationInvoice" after="seeConfigurableProductInItemsOrdered"/>
        <click selector="{{AdminOrderDetailsMainActionsSection.invoice}}" stepKey="clickInvoiceAction" after="closeAdminNotificationInvoice"/>
        <seeInCurrentUrl url="{{AdminInvoiceNewPage.url}}" stepKey="seeOrderInvoiceUrl" after="clickInvoiceAction"/>
-        <see selector="{{AdminHeaderSection.pageTitle}}" userInput="New Invoice" stepKey="seePageNameNewInvoicePage" after="seeOrderInvoiceUrl"/>
+        <actionGroup ref="AssertAdminPageTitleActionGroup" stepKey="seePageNameNewInvoicePage" after="seeOrderInvoiceUrl">


Can we do the same for the seePageNameMatchesOrderIdAfterInvoice stepKey, since we're checking the page title there as well?

eduard13 · 2021-06-20T06:49:03Z

Hi @Usik2203, are willing to continue the progress on this PR?
Thank you.

Usik2203 · 2021-06-22T12:43:55Z

@magento run all tests

magento-automated-testing · 2021-06-22T12:44:03Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-06-23T05:37:14Z

@magento run Unit Tests, Integration Tests, Functional Tests EE

magento-automated-testing · 2021-06-23T05:37:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-06-23T09:35:37Z

@magento run Integration Tests

magento-automated-testing · 2021-06-23T09:35:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-06-23T14:15:28Z

app/code/Magento/Backend/Test/Mftf/Test/AdminStartupPageTest.xml

+        </after>
+
+        <actionGroup ref="CliCacheCleanActionGroup" stepKey="cleanInvalidatedCaches">
+            <argument name="tags" value="config full_page"/>


@Usik2203 are we required to clean the full_page cache to see the changes? Is cleaning the caches really needed here?
I'd probably even completely remove this test and preserve the title assertions only.

Thank you.

sidolov · 2021-10-14T19:01:48Z

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2021-10-14T19:02:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-10-15T17:28:27Z

@magento run Functional Tests CE,Functional Tests B2B

magento-automated-testing · 2021-10-15T17:28:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-10-17T17:01:22Z

@magento run Database Compare, Integration Tests, Magento Health Index, Semantic Version Checker, Static Tests, Unit Tests, WebAPI Tests, Sample Data Tests B2B, Sample Data Tests EE, Sample Data Tests CE

magento-automated-testing · 2021-10-17T17:01:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-18T17:02:28Z

Hi @sidolov, thank you for the review.
ENGCOM-9263 has been created to process this Pull Request

…leActionGroup #32771

m2-assistant · 2021-10-23T15:04:47Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Added AdminStartupPageTest and AssertAdminPageTitleActionGroup

29ddaf9

magento-engcom-team added Component: Backend Component: PageCache Component: Reports Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 16, 2021

Usik2203 added 2 commits April 26, 2021 15:15

Merge branch '2.4-develop' into mftf-startap-page

864b2a9

Merge branch '2.4-develop' into mftf-startap-page

f88cb85

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 4, 2021

m2-community-project bot added this to Pending Review in High Priority Pull Requests Dashboard May 4, 2021

m2-community-project bot added the Progress: pending review label May 4, 2021

eduard13 self-assigned this Jun 2, 2021

m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Jun 2, 2021

m2-community-project bot removed the Progress: pending review label Jun 2, 2021

eduard13 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review labels Jun 2, 2021

m2-community-project bot added the Progress: review label Jun 2, 2021

m2-community-project bot moved this from Review in Progress to Pending Review in High Priority Pull Requests Dashboard Jun 2, 2021

m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Jun 2, 2021

m2-community-project bot removed the Progress: pending review label Jun 2, 2021

eduard13 requested changes Jun 2, 2021

View reviewed changes

m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Jun 2, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Jun 2, 2021

m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Jun 22, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Jun 22, 2021

eduard13 reviewed Jun 23, 2021

View reviewed changes

Merge branch '2.4-develop' into mftf-startap-page

18c5a21

sidolov approved these changes Oct 18, 2021

View reviewed changes

m2-community-project bot assigned sidolov Oct 18, 2021

m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 18, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Oct 18, 2021

sidolov moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Oct 18, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Oct 18, 2021

magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2021

ENGCOM-9263: [MFTF] Added AdminStartupPageTest and AssertAdminPageTit…

d577a65

…leActionGroup #32771

magento-engcom-team merged commit 787b1c4 into magento:2.4-develop Oct 23, 2021

sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Oct 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MFTF] Added AdminStartupPageTest and AssertAdminPageTitleActionGroup #32771

[MFTF] Added AdminStartupPageTest and AssertAdminPageTitleActionGroup #32771

Usik2203 commented Apr 16, 2021

m2-assistant bot commented Apr 16, 2021

Usik2203 commented Apr 29, 2021

magento-automated-testing bot commented Apr 29, 2021

eduard13 left a comment

eduard13 Jun 2, 2021

Usik2203 Jun 22, 2021

eduard13 commented Jun 20, 2021

Usik2203 commented Jun 22, 2021

magento-automated-testing bot commented Jun 22, 2021

eduard13 commented Jun 23, 2021

magento-automated-testing bot commented Jun 23, 2021

eduard13 commented Jun 23, 2021

magento-automated-testing bot commented Jun 23, 2021

eduard13 Jun 23, 2021

sidolov commented Oct 14, 2021

magento-automated-testing bot commented Oct 14, 2021

sidolov commented Oct 15, 2021

magento-automated-testing bot commented Oct 15, 2021

eduard13 commented Oct 17, 2021

magento-automated-testing bot commented Oct 17, 2021

magento-engcom-team commented Oct 18, 2021

m2-assistant bot commented Oct 23, 2021

[MFTF] Added AdminStartupPageTest and AssertAdminPageTitleActionGroup #32771

[MFTF] Added AdminStartupPageTest and AssertAdminPageTitleActionGroup #32771

Conversation

Usik2203 commented Apr 16, 2021

Description (*)

m2-assistant bot commented Apr 16, 2021

Usik2203 commented Apr 29, 2021

magento-automated-testing bot commented Apr 29, 2021

eduard13 left a comment

Choose a reason for hiding this comment

eduard13 Jun 2, 2021

Choose a reason for hiding this comment

Usik2203 Jun 22, 2021

Choose a reason for hiding this comment

eduard13 commented Jun 20, 2021

Usik2203 commented Jun 22, 2021

magento-automated-testing bot commented Jun 22, 2021

eduard13 commented Jun 23, 2021

magento-automated-testing bot commented Jun 23, 2021

eduard13 commented Jun 23, 2021

magento-automated-testing bot commented Jun 23, 2021

eduard13 Jun 23, 2021

Choose a reason for hiding this comment

sidolov commented Oct 14, 2021

magento-automated-testing bot commented Oct 14, 2021

sidolov commented Oct 15, 2021

magento-automated-testing bot commented Oct 15, 2021

eduard13 commented Oct 17, 2021

magento-automated-testing bot commented Oct 17, 2021

magento-engcom-team commented Oct 18, 2021

m2-assistant bot commented Oct 23, 2021