-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ui-Select (Multiselect) close button issues #33098
Fix Ui-Select (Multiselect) close button issues #33098
Conversation
Fix css for close action (remove item) for ui-select with multiple = false
Fix css for close action (remove item) for ui-select with multiple = true when used in a modal
Hi @LyraGhost. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved
Hi @Den4ik, thank you for the review. |
@LyraGhost thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run WebAPI Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
✔️ QA Passed Manual testing scenario:
Actual Result: ✔️ After: ✔️
Actual Result: ✔️ After: ✔️ Tested all the manual scenarios, no impact on regression testing. |
Hi @LyraGhost, thank you for your contribution! |
Description (*)
Fix positioning of remove/close button for ui-select in single-select mode (in form and in modal)
![image](https://user-images.githubusercontent.com/10944977/120029337-f8491880-bfc3-11eb-911d-5bc2b016915d.png)
![image](https://user-images.githubusercontent.com/10944977/120029549-42ca9500-bfc4-11eb-8fd6-29ab88d934b9.png)
Before:
After:
Fix positioning of remove/close button in multiple-select mode when used in a modal (see linked issue)
![image](https://user-images.githubusercontent.com/10944977/120030630-b7520380-bfc5-11eb-8f25-4122efa4ab95.png)
Fixed Issues (if relevant)
(PR was never opened for issue and was similar to fix I was applying for single-select mode, so I included it)
Manual testing scenarios (*)
For fix 1. above:
For fix 2. above:
Questions or comments
I'm not really sure if tests are applicable to this, but if so I'll need help writing them as I don't know how to go about doing so.
Contribution checklist (*)