Fix Ui-Select (Multiselect) close button issues

[LyraGhost]

Description (*)

1. Fix positioning of remove/close button for ui-select in single-select mode (in form and in modal)
   Before:
   
   After:
   

2. Fix positioning of remove/close button in multiple-select mode when used in a modal (see linked issue)
   

Fixed Issues (if relevant)

1. Also Fixes Magento 2.3.4 .action-close broken when Multiselect is used in a modal #27240
   (PR was never opened for issue and was similar to fix I was applying for single-select mode, so I included it)

Manual testing scenarios (*)

For fix 1. above:

1. Create form ui component with ui-select field.
2. Set the following config for the field:
   • multiple: false
   • chipsEnabled: false
   • isRemoveSelectedIcon: true

For fix 2. above:

1. Create form ui component with modal.
2. Add ui-select field in modal.

Questions or comments

I'm not really sure if tests are applicable to this, but if so I'll need help writing them as I don't know how to go about doing so.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @LyraGhost. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

✅ Approved

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-9104 has been created to process this Pull Request

[magento-engcom-team]

@LyraGhost thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Charlie]

✔️ QA Passed

Manual testing scenario:

1. Created Ui Form and added Ui-Select component in it with following configuration

• multiple: false
• chipsEnabled: false
• isRemoveSelectedIcon: true

Actual Result: ✔️
 1. Verified that Close button position is correct and properly inline.


After: ✔️  

Before: ✖️ 



2. Created Ui Form and added Ui-multiselct component in it with below configuration

• multiple: true
• chipsEnabled: false
• isRemoveSelectedIcon: true

Actual Result: ✔️
1. Verified that Close button position is correct and properly inline.


After: ✔️  




Before: ✖️ 

Tested all the manual scenarios, no impact on regression testing. 

[m2-assistant]

Hi @LyraGhost, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.