Replace repetitive actions with Action groups in StorefrontInactiveCatalogRuleTest

[kate-kyzyma]

Description (*)

The test is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Run the test in the local environment and verified that it runs successfully.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Replace repetitive actions with Action groups in StorefrontInactiveCatalogRuleTest #33556: Replace repetitive actions with Action groups in StorefrontInactiveCatalogRuleTest

[m2-assistant]

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[kate-kyzyma]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[eduard13]

@magento run WebAPI Tests, Functional Tests CE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[eduard13]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-9154 has been created to process this Pull Request

[engcom-Charlie]

@magento create issue

[engcom-Charlie]

Hi @eduard13 and @kate-kyzyma

I have done the required setup to test this PR.

When I am running vendor/bin/mftf run:test StorefrontInactiveCatalogRuleTest --remove test case getting below error.

Can you please mention, is this the expected behaviour, as the test case is showing 0 assertions and 1 failure.

Thanks in advance!

[eduard13]

Hi @engcom-Charlie, thank you for testing this one, really strange that all the checks are green 😕.
@kate-kyzyma, could you please check the reported above issue?

[engcom-Charlie]

@eduard13 Thanks for confirming.

❌ QA not Passed


I have done the required setup to test this PR.

When I am running vendor/bin/mftf run:test StorefrontInactiveCatalogRuleTest --remove test case getting below error.

[engcom-Charlie]

Hi @eduard13 and @kate-kyzyma

I have retested this issue and found that its working fine. I was missing out few steps of MFTF related setup which was causing some issue when I was testing.

Sorry for the inconvenience.

The MFTF test case vendor/bin/mftf run:test StorefrontInactiveCatalogRuleTest --remove is valid and working as expected.

The test case is working fine and green in build.

✔️ QA Passed

[m2-assistant]

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.