-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove casting to int on increment ID which can be prefixed by a string #33369
Remove casting to int on increment ID which can be prefixed by a string #33369
Conversation
Hi @sippsolutions. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Thanks for contribute! Can you add some screenshot show problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sippsolutions,
Could you add escaping for the string, and cover it with some type of automated test?
app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml
Outdated
Show resolved
Hide resolved
Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @ihor-sviziev, thank you for the review. |
@magento create issue |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Invoice ID used to be 0 After: ✔️ Invoice Id is printed correctly keeping prefix with string Since it is a issue with a custom changes in the invoice related code, there is no additional testing or regression is required. |
Description (*)
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: