Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] AdminApplyTierPriceToProductTest refactoring #33406

Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from
Open

[MFTF] AdminApplyTierPriceToProductTest refactoring #33406

wants to merge 12 commits into from

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Jul 2, 2021 •
edited by m2-assistant bot

This PR is to refactor AdminApplyTierPriceToProductTest according to the best practices

Resolved issues:

  1. resolves [Issue] [MFTF] AdminApplyTierPriceToProductTest refactoring #34383: [MFTF] AdminApplyTierPriceToProductTest refactoring

@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2021

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jul 2, 2021

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jul 6, 2021

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak AnnaAPak changed the title WIP [MFTF] AdminApplyTierPriceToProductTest refactoring [MFTF] AdminApplyTierPriceToProductTest refactoring Jul 6, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jul 6, 2021

@magento run all tests

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jul 6, 2021
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@shikhamis11 shikhamis11 self-requested a review August 15, 2021 18:29
@shikhamis11
Copy link
Member

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@shikhamis11
Copy link
Member

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 19, 2021
Closed
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 19, 2021
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Oct 19, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Nov 7, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 5, 2022

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 6, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhamis11 shikhamis11 Awaiting requested review from shikhamis11

Assignees
No one assigned
Labels
Component: Catalog Component: Checkout Component: Config Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] AdminApplyTierPriceToProductTest refactoring
4 participants
@AnnaAPak @shikhamis11 @engcom-Alfa @magento-engcom-team