validate-rating is not working, selector of review rating is changed

[taoufiqaitali]

validate-rating is not working, selector of review rating is changed

Description (*)

Related Pull Requests

Manual testing scenarios (*)

1. ... create review from backend
2. ... dont select rating
3. ... Click Save
4. ... it will pass without validation

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] validate-rating is not working, selector of review rating is changed #33424: validate-rating is not working, selector of review rating is changed

[m2-assistant]

Hi @taoufiqaitali. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[shikhamis11]

@magento create issue

[shikhamis11]

hi @taoufiqaitali,
Thank you for the Pull Request. Please also provide MFTF test coverage for your solution.

[taoufiqaitali]

hi @taoufiqaitali,
Thank you for the Pull Request. Please also provide MFTF test coverage for your solution.

Hi @shikhamis11
i fixed just one line,
how i can prepar MFTF, can you give an example

[shikhamis11]

@taoufiqaitali According to the definition of done all changes should be covered by autotests.
You can create an MFTF test with the scenario below

1. Login to Backend

2. go to the Review section

3. click on add new review

4. Select your product

5. add review

6. don't select a rating

7. verify form i.e rating is not selected

8. Click Save

9. it will show a validation error

you can take references from already created tests
https://github.com/magento/magento2/tree/2.4-develop/app/code/Magento/Review/Test/Mftf/Test
also, you can take reference from here https://devdocs.magento.com/mftf/docs/getting-started.html