Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language in cookie_status.phtml #33742

Merged

Conversation

sean-breeden
Copy link
Contributor

@sean-breeden sean-breeden commented Aug 10, 2021

The cookie disabled message contains a poorly-worded sentence. This is a suggested fix to the sentence. Dropped "in the case".

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix language in cookie_status.phtml #34524: Fix language in cookie_status.phtml

The cookie disabled message contains a poorly-worded sentence. This is a suggested fix to the sentence. Dropped "in the case".
@m2-assistant
Copy link

m2-assistant bot commented Aug 10, 2021

Hi @sean-breeden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Aug 10, 2021

Hi @sean-breeden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sean-breeden sean-breeden reopened this Aug 10, 2021
@m2-community-project m2-community-project bot added this to Ready for Testing in Pull Requests Dashboard Aug 11, 2021
@nuzil nuzil added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Type: Code Cleanup and removed Progress: ready for testing labels Aug 11, 2021
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-9179 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-9179 has been created to process this Pull Request

@Den4ik Den4ik added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Aug 13, 2021
@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9179 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Nov 3, 2021
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 97c312b into magento:2.4-develop Oct 28, 2022
@andrewbess
Copy link
Contributor

This PR has already been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Theme Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Code Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fix language in cookie_status.phtml
9 participants