Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed lonely <br> tags in payment.html template, when invisible captcha is enabled or completely disabled #33892

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Removed lonely <br> tags in payment.html template, when invisible captcha is enabled or completely disabled #33892

merged 3 commits into from
Oct 28, 2022

Conversation

dudzio12
Copy link
Member

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Lonely <br> tags in payment.html template #33820

Manual testing scenarios (*)

  1. Magento 2.4-develop with blank/Luma theme enabled.

Questions or comments

I need help with proposed stylesheet changes. Is it ok as there is now?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2021

Hi @dudzio12. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Aug 23, 2021
@dudzio12
Copy link
Member Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @dudzio12. Thank you for your request. I'm working on Magento instance for you.

@dudzio12
Copy link
Member Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-deployment-service
Copy link

Hi @dudzio12, here is your Magento Instance: https://699630cfbaef5677f9b406a57538b414.instances.magento-community.engineering
Admin access: https://699630cfbaef5677f9b406a57538b414.instances.magento-community.engineering/admin_5e28
Login: 95991fc1
Password: e4b9bb514b18

@dudzio12
Copy link
Member Author

image

@dudzio12
Copy link
Member Author

image

I think there is completely no point to adding any additional styles.

BarnyShergold
BarnyShergold approved these changes Aug 24, 2021
View reviewed changes
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but for some reason some tests are failing

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 24, 2021
@magento-engcom-team
Copy link
Contributor

Hi @BarnyShergold, thank you for the review.
ENGCOM-9193 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@dudzio12 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dudzio12
Copy link
Member Author

@BarnyShergold - thanks for approval, tests are failing because of something else 👎

@BarnyShergold BarnyShergold added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 24, 2021
@m2-community-project m2-community-project bot added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Aug 24, 2021
@BarnyShergold
Copy link

@magento run Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9193 has been created to process this Pull Request

@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Aug 24, 2021
@BarnyShergold
Copy link

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@magento run Functional Tests EE,Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@BarnyShergold
Copy link

@dudzio12 - Finally all tests have passed!

@dudzio12 dudzio12 closed this Dec 9, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Dec 9, 2021
@dudzio12 dudzio12 mentioned this pull request Feb 16, 2022
Closed
1 task
@dudzio12 dudzio12 reopened this Feb 16, 2022
@m2-assistant
Copy link

m2-assistant bot commented Feb 16, 2022

Hi @dudzio12. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Testing in Pull Requests Dashboard Feb 16, 2022
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 1e2d4da into magento:2.4-develop Oct 28, 2022
@engcom-Delta engcom-Delta added Progress: testing in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Progress: ready for testing and removed Progress: ready for testing Progress: testing in progress labels Jan 9, 2024
@andrewbess
Copy link

This PR has already been merged

@andrewbess andrewbess removed this from Ready for Testing in Pull Requests Dashboard Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@BarnyShergold BarnyShergold BarnyShergold approved these changes

Assignees

@Den4ik Den4ik

@BarnyShergold BarnyShergold

Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Checkout Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Release Line: 2.4 Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lonely <br> tags in payment.html template
7 participants
@dudzio12 @magento-engcom-team @BarnyShergold @andrewbess @Den4ik @engcom-Delta @magento-devops-reposync-svc