-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#34063 fixed issue with price block cache for different zones #34207
#34063 fixed issue with price block cache for different zones #34207
Conversation
Hi @vovsky. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Huh, I knew this sounded familiar: #9562 (comment) 😄 The "fix" I mentioned in the post below that comment was reverted by b2e58d5 since Magento 2.3.3 But I believe your PR is probably a better way to solve this then to stop caching the final price box. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
5 similar comments
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests look not related to changes from this PR.
Hi @ihor-sviziev, thank you for the review.
|
I think covering with test will be too hard there, so marked that test coverage isn't required |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Rich Snippets Price attributes are missing After: ✔️ Rich Snippets Price attributes are visible There is nothing else needs to be tested as part of regression since it is specific to updating attributes of the element. |
@vovsky @engcom-Alfa, can it be checked with some integration or MFTF test? |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@ihor-sviziev @engcom-Alfa I'm working on MFTF test to cover this case |
Thanks for your contribution @vovsky , Moving the ticket to "Extended Testing" till the completion of the Auto-Tests. |
Hi @vovsky, thank you for your contribution! |
Hi @sidolov @engcom-Alfa, |
Description (*)
This PR fixes issue with price block cache for different zones.
Price block cache for "related product view" and PDP view was the same. As result on PDP price block doesn't have Rich Snippets (offers) markup if it was already cached in related products section of other product.
Fixed Issues (if relevant)
Manual testing scenarios (*)