#34063 fixed issue with price block cache for different zones

[vovsky]

Description (*)

This PR fixes issue with price block cache for different zones.
Price block cache for "related product view" and PDP view was the same. As result on PDP price block doesn't have Rich Snippets (offers) markup if it was already cached in related products section of other product.

Fixed Issues (if relevant)

1. Fixes Related Products Block Breaks Rich Snippets Price on Product View #34063

Manual testing scenarios (*)

1. Create Product A
2. Create Product B as related of product A
3. Visit PDP of product A
4. Visit PDP of product B
5. Notice that price block doesn't have rich snippets.

[m2-assistant]

Hi @vovsky. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

Huh, I knew this sounded familiar: #9562 (comment) 😄

The "fix" I mentioned in the post below that comment was reverted by b2e58d5 since Magento 2.3.3

But I believe your PR is probably a better way to solve this then to stop caching the final price box.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

✔ Approved.

Failing tests look not related to changes from this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9240 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ihor-sviziev]

I think covering with test will be too hard there, so marked that test coverage isn't required

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Have Magento instance installed with sample data

Manual testing scenario:

1. Set up a simple product A with one related simple product B

2. Frontend: Open the Product A's product details page (Make sure Product B is available in the below related products list)

3. View the Product B's product details page. Inspect the price text from it, and validate the Rich Snippets Price attributes in the source code

Before: ✖️ Rich Snippets Price attributes are missing

After: ✔️ Rich Snippets Price attributes are visible

There is nothing else needs to be tested as part of regression since it is specific to updating attributes of the element.

[ihor-sviziev]

@vovsky @engcom-Alfa, can it be checked with some integration or MFTF test?

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[vovsky]

@ihor-sviziev @engcom-Alfa I'm working on MFTF test to cover this case

[engcom-Alfa]

@ihor-sviziev @engcom-Alfa I'm working on MFTF test to cover this case

Thanks for your contribution @vovsky , Moving the ticket to "Extended Testing" till the completion of the Auto-Tests.

[m2-assistant]

Hi @vovsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

Hi @sidolov @engcom-Alfa,
FYI the PR was already merged, but test coverage wasn't added.
Please don't revert changes from this PR. The changes themselves look good.
Test coverage for this case might be added in a separate PR.