Ignore all .phpunit.result.cache files in the dev/tests directory

[hostep]

Description (*)

When following the instructions for running the functional graphql tests, you'll notice that afterwards your git status is dirty. Because the file dev/tests/api-functional/.phpunit.result.cache gets generated by running those tests. So we should ignore that file in git.

Related Pull Requests

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

1. Follow the instructions for running the functional graphql tests (you might need a workaround mentioned over here to get it working)
2. Not expecting the git status to be dirty

Note for the release notes writers

This doesn't deserve mentioning in the release notes, as it doesn't fix something that users of Magento run into.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hostep. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9261 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ihor-sviziev]

No manual testing required

[ihor-sviziev]

@hostep,
I also got the same thing for unit tests. Could you check it for other test types and add it to .gitignore as well?

[hostep]

Hmm, then maybe we should add a more global .gitignore file in the dev/tests directory which ignores all .phpunit.result.cache files in all subdirectories?

[ihor-sviziev]

@hostep I think it's great idea!

[hostep]

Okay, done!

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9261 has been created to process this Pull Request

[ihor-sviziev]

Just tested locally - everything works fine.

✔ QA passed

Before

❌On the 2.4-develop branch the output of git status:

On branch 2.4-develop
Your branch is up to date with 'origin/2.4-develop'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .env
        dev/tests/acceptance/.phpunit.result.cache
        dev/tests/api-functional/.phpunit.result.cache
        dev/tests/integration/.phpunit.result.cache
        dev/tests/setup-integration/.phpunit.result.cache
        dev/tests/unit/.phpunit.result.cache

nothing added to commit but untracked files present (use "git add" to track)

After

✔ On the extra-phpunit-file-to-ignore (PR) branch the output of git status:

On branch extra-phpunit-file-to-ignore
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .env

nothing added to commit but untracked files present (use "git add" to track)

Note: Locally I have the .env file, so it's not related to this PR.

[m2-assistant]

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.