Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest #34410

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest #34410

merged 4 commits into from
Nov 5, 2021

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Oct 22, 2021 •
edited by m2-assistant bot
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Tests are refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

Run test locally

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest #34414: Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest

@m2-assistant
Copy link

m2-assistant bot commented Oct 22, 2021

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 22, 2021
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Oct 22, 2021
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma kate-kyzyma changed the title Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest Oct 22, 2021
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@shikhamis11 shikhamis11 self-requested a review October 24, 2021 11:52
@shikhamis11
Copy link
Member

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 24, 2021
Closed
5 tasks
shikhamis11
shikhamis11 requested changes Oct 24, 2021
View reviewed changes
app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateDuplicateCategoryTest.xml Outdated
@@ -36,6 +36,9 @@
</actionGroup>

<!-- Assert error message -->
<see selector="{{AdminCategoryMessagesSection.errorMessage}}" userInput="The value specified in the URL Key field would generate a URL that already exists." stepKey="seeErrorMessage"/>
<actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="assertErrorMessage">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep original stepKey i.e seeErrorMessage in actionGroup to avoid semantic version failure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @shikhamis11!

The issue is fixed. Please, check.

@m2-community-project m2-community-project bot moved this from Pending Review to Changes Requested in Pull Requests Dashboard Oct 24, 2021
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Oct 25, 2021
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 28, 2021
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Oct 28, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 29, 2021
@shikhamis11 shikhamis11 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 29, 2021
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, thank you for the review.
ENGCOM-9317 has been created to process this Pull Request
✳️ @shikhamis11, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@shikhamis11 shikhamis11 moved this from Ready for Testing to Pending Approval in High Priority Pull Requests Dashboard Oct 29, 2021
@shikhamis11 shikhamis11 moved this from Pending Approval to Merge in Progress in High Priority Pull Requests Dashboard Oct 29, 2021
@m2-community-project m2-community-project bot moved this from Merge in Progress to Pending Approval in High Priority Pull Requests Dashboard Oct 29, 2021
@m2-community-project m2-community-project bot moved this from Pending Approval to Merge in Progress in High Priority Pull Requests Dashboard Oct 29, 2021
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Nov 5, 2021
magento-engcom-team pushed a commit that referenced this pull request Nov 5, 2021
@sidolov
ENGCOM-9317: Replace repetitive actions with Action Groups in AdminCr…
89ec9dd 
…eateDuplicateCategoryTest and AdminCreateDuplicateProductTest #34410
@magento-engcom-team magento-engcom-team merged commit db8e9be into magento:2.4-develop Nov 5, 2021
@sidolov sidolov moved this from Ready for Testing to Recently Merged in High Priority Pull Requests Dashboard Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhamis11 shikhamis11 shikhamis11 approved these changes

Assignees

@shikhamis11 shikhamis11

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Release Line: 2.4
Projects
None yet
Milestone
No milestone
4 participants
@kate-kyzyma @shikhamis11 @magento-engcom-team @sidolov