Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace repetitive actions with Action Groups in AdminCreateStoreViewTest #34552

Merged
merged 4 commits into from Apr 5, 2022
Merged

Replace repetitive actions with Action Groups in AdminCreateStoreViewTest #34552

merged 4 commits into from Apr 5, 2022

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Nov 5, 2021 •
edited by m2-assistant bot

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Test is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Replace repetitive actions with Action Groups in AdminCreateStoreViewTest #34631: Replace repetitive actions with Action Groups in AdminCreateStoreViewTest

@m2-assistant
Copy link

m2-assistant bot commented Nov 5, 2021

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 5, 2021
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 11, 2021
@shikhamis11 shikhamis11 self-assigned this Nov 13, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Nov 13, 2021
@shikhamis11
Copy link
Member

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 13, 2021
Closed
5 tasks
@shikhamis11
Copy link
Member

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@shikhamis11
Copy link
Member

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 1, 2021
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, thank you for the review.
ENGCOM-9358 has been created to process this Pull Request
✳️ @shikhamis11, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@shikhamis11 shikhamis11 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 1, 2021
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

The PR has updates related to the cod-refactoring in the app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml test file. As per the auto-test results, the code changes executed successfully passed.

Since it is an existing test and just has been refactored, no test case creation is required as part of regression testing as well.
Hence approving the changes!
Thanks

@engcom-Alfa engcom-Alfa self-assigned this Dec 9, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 9, 2021
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 9, 2021
@m2-community-project m2-community-project bot moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 9, 2021
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Dec 9, 2021
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 5, 2022
@sidolov
ENGCOM-9358: Replace repetitive actions with Action Groups in AdminCr…
0370a7f 
…eateStoreViewTest #34552
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 8e66f69 into magento:2.4-develop Apr 5, 2022
@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhamis11 shikhamis11 shikhamis11 approved these changes

Assignees

@shikhamis11 shikhamis11

@engcom-Alfa engcom-Alfa

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Store Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Replace repetitive actions with Action Groups in AdminCreateStoreViewTest
7 participants
@kate-kyzyma @shikhamis11 @magento-engcom-team @engcom-Alfa @sdzhepa @magento-devops-reposync-svc @m2-github-services