-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace repetitive actions with Action Groups in AdminMoveCategoryAndCheckUrlRewritesTest #34935
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @kate-kyzyma. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Database Compar, Functional Tests B2B, WebAPI Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Database Compar |
Failed to run the builds. Please try to re-run them later. |
@magento run Database Compare |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Database Compare |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kate-kyzyma.
Thanks for work on this PR.
I believe that we can replace all tests that contains <seeElement selector="{{StorefrontCategoryMainSection.CategoryTitle"
in this PR.
Are you free to update PR?
Hi @kate-kyzyma, Thank you for your contribution! I will look into the changes requested in this comment of replacing the <seeElement selector="{{StorefrontCategoryMainSection.CategoryTitle" with added Action group. Thank you! |
…AdminMoveCategoryAndCheckUrlRewritesTest
@magento create issue |
…ryTitle with new Actiongroup
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
I have replaced all tests that contains selector="{{StorefrontCategoryMainSection.CategoryTitle" with “StorefrontAssertCategoryTitleActionGroup” Action group. @Den4ik, can you please review the latest changes. Thank you! |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Test is refactored according to the best practices followed by MFTF
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: