Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace repetitive actions with Action Groups in AdminMoveCategoryAndCheckUrlRewritesTest #34935

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Jan 5, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Test is refactored according to the best practices followed by MFTF

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Replace repetitive actions with Action Groups in AdminMoveCategoryAndCheckUrlRewritesTest #35051: Replace repetitive actions with Action Groups in AdminMoveCategoryAndCheckUrlRewritesTest

@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2022

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 5, 2022
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Database Compar, Functional Tests B2B, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kate-kyzyma
Copy link
Contributor Author

@magento run Database Compar

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@kate-kyzyma
Copy link
Contributor Author

@magento run Database Compare

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jan 12, 2022

@magento run Database Compare

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kate-kyzyma.
Thanks for work on this PR.

I believe that we can replace all tests that contains <seeElement selector="{{StorefrontCategoryMainSection.CategoryTitle" in this PR.
Are you free to update PR?

@m2-community-project m2-community-project bot added this to Changes Requested in Pull Requests Dashboard Jan 12, 2022
@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 13, 2022
@m2-community-project m2-community-project bot removed this from Changes Requested in Pull Requests Dashboard Jan 13, 2022
@engcom-Charlie engcom-Charlie self-assigned this Jan 17, 2022
@engcom-Charlie
Copy link
Contributor

Hi @kate-kyzyma,

Thank you for your contribution!

I will look into the changes requested in this comment of replacing the <seeElement selector="{{StorefrontCategoryMainSection.CategoryTitle" with added Action group.

Thank you!

@engcom-Charlie
Copy link
Contributor

@magento create issue

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

I have replaced all tests that contains  selector="{{StorefrontCategoryMainSection.CategoryTitle" with “StorefrontAssertCategoryTitleActionGroup” Action group.

@Den4ik, can you please review the latest changes.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Replace repetitive actions with Action Groups in AdminMoveCategoryAndCheckUrlRewritesTest
6 participants