Exclude JS from move JS code to the bottom of the page

[in-session]

Currently there is no possibility to exclude global single files or inline scripts with the function "Move JS code to the bottom of the page". However, this is necessary in some areas, for example with the Google Tag Manager or other critical JS resources.

Configuration>Developer>JavaScript Settings>Move JS code to the bottom of the page

[m2-assistant]

Hi @in-session. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

Hi @in-session.
Thanks for PR.
I believe that we can remove data-move="false" string from result context after detection.
What do you think?

[in-session]

Hi @in-session. Thanks for PR. I believe that we can remove data-move="false" string from result context after detection. What do you think?

@Dan4ik
Do you have an idea for that? I am a bit overwhelmed with work right now.

[mrtuvn]

So if in file xml layout dev add specific file external/custom js files have attribute "data-move" equal false magento will act not move these files to bottom ?
For very specific case i think the better option is instead excludition by code we can choose conditional include or load
Can you add some content for clarify idea of this improve?

From my experiences with requirejs in magento stack current if we require it somewhere in js codebase you cannot remove it from layout. The only way for exclude is find place where it define and add some condition or remove it completely

[in-session]

So if in file xml layout dev add specific file external/custom js files have attribute "data-move" equal false magento will act not move these files to bottom ? For very specific case i think the better option is instead excludition by code we can choose conditional include or load Can you add some content for clarify idea of this improve?

From my experiences with requirejs in magento stack current if we require it somewhere in js codebase you cannot remove it from layout. The only way for exclude is find place where it define and add some condition or remove it completely
@mrtuvn

Yes the idea behind it is to exclude scripts from moving
For example with the use of third cookie consent tools or other libraries like workbox etc., these must not be loaded async and must be added on top, like:

<script src="https://privacy-proxy.usercentrics.eu/latest/uc-block.bundle.js" src_type="url" data-move="false" />

But of course this also refers to inline scripts which are integrated via phtml, like google tag manager:

<?php
$scriptTagManager = <<<SCRIPT
    (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
    new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
    j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
    'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
    })(window,document,'script','dataLayer','GTM-XXXXXX');
SCRIPT;
?>
<?= /* @noEscape */ $secureRenderer->renderTag('script', ['data-cfasync'=>'false','data-move'=>'false'], $scriptTagManager, false) ?>

You can find many entries of the missing function:
https://www.google.com/search?q=magento+2+exclude+js+move+bottom+&sxsrf=AOaemvI_7G8jjy9sbgXZgj_BLi3JiOZBXA%3A1642320634993&ei=-tLjYcTpO7OW9u8P49uxsAg&ved=0ahUKEwjEzriQ6bX1AhUzi_0HHeNtDIYQ4dUDCA4&uact=5&oq=magento+2+exclude+js+move+bottom+&gs_lcp=Cgdnd3Mtd2l6EAMyBQgAEM0CMgUIABDNAjoHCAAQRxCwAzoICCEQFhAdEB5KBAhBGABKBAhGGABQ3l9Y7pABYIqUAWgFcAJ4AIABhQGIAeoIkgEEMTMuMZgBAKABAaABAsgBCMABAQ&sclient=gws-wiz

[vseager]

@in-session what is the status on this?

[in-session]

@vseager
Due to time constraints I can't continue right now. You are welcome to make suggestions for changes.
With me it currently runs only the test has not gone through.

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[in-session]

Hi @in-session. Thanks for PR. I believe that we can remove data-move="false" string from result context after detection. What do you think?

I would say no as it is better for frontend debugging to check the values.

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

@in-session Can you please resolved the conflicts?

[in-session]

@magento run all tests

[magento-automated-testing]

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.