-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up catalogrule_product_price_replica
table
#35033
Clean up catalogrule_product_price_replica
table
#35033
Conversation
See magento#31752 for details. Related commits have been labelled with MC-41807.
Hi @fredden. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @engcom-Hotel, |
@magento run Functional Tests B2B, Magento Health Index, Unit Tests PS: I think adding a new data patch shouldn't cause MHI failure, so that I would treat it as a false positive. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests look not related to changes from this PR.
Hi @ihor-sviziev, thank you for the review. |
As we got the approval for Magento Health Index test failure for JIRA, moving this PR to Merge in Progress. Thank you! |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi guys, what would be the status here? Would love to see this being merged. But it's been pretty quiet here since a few months 🙂 |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@hostep Trying to get it updated and going again. Still needs a Health Check build figured out so will definitely take extra time. |
Got required approvals for positive case of Magento Health Index test in JIRA hence moving it to Merge in Progress. Thank you! |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Description
There was a bug which caused the
catalogrule_product_price_replica
table to become unnecessarily large. The bug causing the growth has been resolved in Magento version2.4.4
- see #31752 (comment).This schema patch cleans up the damage done by that bug on existing websites. Deleting all entries from this table is safe.
See #31752 for details.
Related Pull Requests
Fixed Issues
Manual testing scenarios
There should be no change to any functionality after applying these changes. This is a data clean-up task.
Questions or comments
None
Contribution checklist