Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up catalogrule_product_price_replica table #35033

Merged

Conversation

fredden
Copy link
Member

@fredden fredden commented Jan 28, 2022

Description

There was a bug which caused the catalogrule_product_price_replica table to become unnecessarily large. The bug causing the growth has been resolved in Magento version 2.4.4 - see #31752 (comment).

This schema patch cleans up the damage done by that bug on existing websites. Deleting all entries from this table is safe.

See #31752 for details.

Related Pull Requests

Fixed Issues

Manual testing scenarios

There should be no change to any functionality after applying these changes. This is a data clean-up task.

Questions or comments

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

See magento#31752 for details.
Related commits have been labelled with MC-41807.
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2022

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jan 28, 2022
@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Feb 1, 2022
@ihor-sviziev
Copy link
Contributor

Hi @engcom-Hotel,
I think such change should have P2 priority as it's basically wasn't fully fixed in #31752 (comment).

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Feb 8, 2022
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Magento Health Index, Unit Tests

PS: I think adding a new data patch shouldn't cause MHI failure, so that I would treat it as a false positive.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Feb 8, 2022
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Feb 8, 2022
@ihor-sviziev ihor-sviziev self-assigned this Feb 8, 2022
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Feb 8, 2022
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9399 has been created to process this Pull Request

@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 9, 2022
@engcom-Charlie
Copy link
Contributor

As we got the approval for Magento Health Index test failure for JIRA, moving this PR to Merge in Progress.

Thank you!

@ishakhsuvarov
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@hostep
Copy link
Contributor

hostep commented Aug 29, 2022

Hi guys, what would be the status here? Would love to see this being merged. But it's been pretty quiet here since a few months 🙂

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ishakhsuvarov
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ishakhsuvarov
Copy link
Contributor

@hostep Trying to get it updated and going again.

Still needs a Health Check build figured out so will definitely take extra time.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Oct 21, 2022

Got required approvals for positive case of Magento Health Index test in JIRA hence moving it to Merge in Progress.

Thank you!

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 4b0cf77 into magento:2.4-develop Nov 24, 2022
@fredden fredden deleted the 31752-clean-up-old-data branch November 24, 2022 18:29
@ishakhsuvarov ishakhsuvarov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: CatalogRule Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
10 participants