Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type definition mapper typo #35109

Merged
merged 1 commit into from Apr 22, 2022
Merged

Fix type definition mapper typo #35109

merged 1 commit into from Apr 22, 2022

Conversation

dudzio12
Copy link
Member

@dudzio12 dudzio12 commented Feb 15, 2022 •
edited by m2-assistant bot

Description (*)

Fixed typo in di.xml

Fixed Issues (if relevant)

  1. Fixes Incorrect 'longblog' database definition, should be 'longblob' #35108

Manual testing scenarios (*)

No need to test

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix type definition mapper typo #35128: Fix type definition mapper typo

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Feb 15, 2022
@dudzio12
Copy link
Member Author

Run all tests

@dudzio12 dudzio12 mentioned this pull request Feb 15, 2022
Closed
5 tasks
@bgorski bgorski self-requested a review February 16, 2022 08:50
@bgorski
Copy link
Contributor

bgorski commented Feb 16, 2022 •
edited

@dudzio12 thank you for the contribution! Can you provide steps for testing this? This is an obvious typo and the PR will get accepted, but when it does, the next step is manual testing. Adobe QA engineers will have to know how to trigger the piece of code that you fixed. Also, steps to test/reproduce are important when determining the priority of this.

@bgorski bgorski added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Feb 16, 2022
@bgorski bgorski self-assigned this Feb 16, 2022
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Feb 16, 2022
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Feb 16, 2022
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 17, 2022
@m2-community-project m2-community-project bot removed this from Changes Requested in Pull Requests Dashboard Feb 17, 2022
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Feb 18, 2022
@magento-engcom-team
Copy link
Contributor

Hi @bgorski, thank you for the review.
ENGCOM-9401 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 21, 2022
@engcom-Alfa engcom-Alfa self-assigned this Feb 21, 2022
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Feb 21, 2022
@engcom-Alfa
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 21, 2022
@engcom-Alfa
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Feb 22, 2022
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Feb 22, 2022
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 22, 2022
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Feb 23, 2022
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

This PR is relevant to the the correct of text in the di.xml and has no functional impact and hence no testing required.
Since the auto-test jobs are successfully running with this PR, moving to Merge In Progress.
Thanks for the contribution and collaboration @dudzio12 and @bgorski .

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 80b0bda into magento:2.4-develop Apr 22, 2022
@dudzio12 dudzio12 deleted the 2.4-develop-35108 branch April 22, 2022 18:17
@ishakhsuvarov ishakhsuvarov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgorski bgorski bgorski approved these changes

Assignees

@bgorski bgorski

@engcom-Alfa engcom-Alfa

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix type definition mapper typo Incorrect 'longblog' database definition, should be 'longblob'
5 participants
@dudzio12 @bgorski @magento-engcom-team @engcom-Alfa @magento-devops-reposync-svc