Set default collation to utf8mb4

[sippsolutions]

Description (*)

MySQL 8 interprets utf8 as utf8mb3, which is deprecated:
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-24.html
https://dev.mysql.com/doc/refman/8.0/en/charset-unicode-utf8mb3.html
We should therefor ensure utf8mb4 is used.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Set default collation to utf8mb4 #38085: Set default collation to utf8mb4

[m2-assistant]

Hi @sippsolutions. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sippsolutions]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

Hi @sippsolutions
Thanks for this PR.
Could you please fix failed tests

[sippsolutions]

@Den4ik did you see my changes? the tests are intended to fail.

[Den4ik]

Hi @sippsolutions
Sorry for delay. I don't see any commits after my message.
Unit and Static tests failed on changed file

[sippsolutions]

Hi @Den4ik,
the failing database compare tests cannot be fixed as they state that there are differences in the database structure.
If you look at the changes I made you can see that I changed the default collation for database tables. It is intended that the database structure differs.

[Den4ik]

Hi @sippsolutions
I didn't say about db tests. Only static and unit tests failed for changed file.
I believe that some one from core team could help with this fixes off you don't have time for fix that

[sippsolutions]

@Den4ik that would be awesome :)

[Den4ik]

@sippsolutions Could you resolve merge conflict?

[hostep]

This might be a bit more complex than what it sounds like.

See OpenMage/magento-lts#1036 where an attempt is made to apply a similar change to Magento 1, it contains a bunch of interesting information in the comments.

[Quazz]

magento2/lib/internal/Magento/Framework/DB/Ddl/Table.php

Line 238 in 0a834cc

protected $_options = ['type' => 'INNODB', 'charset' => 'utf8', 'collate' => 'utf8_general_ci'];

Would also need changes, otherwise you'll get mismatched collations which will kill your performance.

[andrewbess]

Hello @sippsolutions
Thank you for your collaboration.
Changes look good for me ✔️.
Let's wait for passing functional tests.

[Den4ik]

Functional tests passed in previous runs.
Checked DB tests and it looks ok

[andrewbess]

Approved

[andrewbess]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Delta]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run Functional Tests CE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Bravo]

Hi,

Internal team has started working on this issue. Most of the code changes are complete. We are trying to get conclusion over DBC failure and are in discussion with PO.

Thanks.

[engcom-Hotel]

As per this comment #35174 (comment), we are moving this issue On hold.

We will update you here about the progress.

Thanks

[engcom-Bravo]

Hi,

All the required changes are done and working with Engineering Manager to speed up. Delivery is aligned for Oct Release.

Thanks.