Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing section when custom role is selected #35439

Merged
merged 4 commits into from Jun 14, 2022
Merged

Missing section when custom role is selected #35439

merged 4 commits into from Jun 14, 2022

Conversation

arifadobe
Copy link
Contributor

@arifadobe arifadobe commented May 6, 2022 •
edited by m2-assistant bot

Description (*)

When we select custom "Roles Resources" then we don't see "Magento Web API" under "Store>Configuration>Services"

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Login to Magento Admin as Administrator
  2. Navigate to "Store>Configuration>Services"
  3. You should be able to see "Magento Web API"
  4. Now set a custom permission by navigating to "System>User Roles"
  5. Select Administrators
  6. Go to Role Resources Tab
  7. Under "Resource Access" select Custom
  8. Now select every checkbox and save the role
  9. Navigate to "Store>Configuration>Services"
  10. You will see "Magento Web API" section is missing
  11. After applying this fix it will remain

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Missing section when custom role is selected #35506: Missing section when custom role is selected

@arifadobe
Missing section when custom role is selected
1d12a0d 
When we select custom "Roles Resources" then we don't see "Magento Web API" under "Store>Configuration>Services"
@arifadobe
Merge pull request #1 from arifadobe/missing-section-for-custom-role
ee676ec 
Missing section when custom role is selected
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2022

Hi @arifadobe. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@arifadobe arifadobe closed this May 6, 2022
@arifadobe arifadobe reopened this May 6, 2022
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard May 10, 2022
@arifadobe
Copy link
Contributor Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @arifadobe. Thank you for your request. I'm working on Magento instance for you.

@arifadobe
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-deployment-service
Copy link

Hi @arifadobe, here is your Magento Instance: https://dadb92e338b8788716ca6a5d26ab3b63.instances.magento-community.engineering
Admin access: https://dadb92e338b8788716ca6a5d26ab3b63.instances.magento-community.engineering/admin_6ef3
Login: f8d6c876
Password: 931789cfc34f

@engcom-Alfa engcom-Alfa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 10, 2022
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard May 10, 2022
@manavluhar
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@arifadobe
Copy link
Contributor Author

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@arifadobe
Copy link
Contributor Author

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request May 20, 2022
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Jun 13, 2022
@ishakhsuvarov
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ishakhsuvarov
Copy link
Contributor

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 20f4b88 into magento:2.4-develop Jun 14, 2022
@ishakhsuvarov ishakhsuvarov moved this from Ready for Testing to Recently Merged in High Priority Pull Requests Dashboard Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Missing section when custom role is selected
5 participants
@arifadobe @manavluhar @ishakhsuvarov @engcom-Alfa @magento-devops-reposync-svc