-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MariaDB Casting is too slow #35564
MariaDB Casting is too slow #35564
Conversation
When the MariaDB is try to cast the entitys_ids from string to integer is to slow, Check: #27129
Hi @osrecio. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @osrecio, |
Hi @ihor-sviziev , I added some manual steps, seems like in the previous PR, not all possibilities were covered. In this PR, when you try to reindex EAV, the query can be vary from:
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento create issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests look not related to changes from this PR.
@magento Functional Tests B2B, Functional Tests CE, Functional Tests EE |
Hi @osrecio & @ihor-sviziev Thanks for your contribution and collaboration!
Here, noticeable thing is, it has taken 2 seconds more time to the prior file changes execution. I re-tried the same scenario twice in my system and found the same 2 seconds more time taken both the times. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @osrecio , Thanks for your contribution and collaboration. As per your comment it should take very less time to reindex EAV.
But I have observed It is still taking longer time to reindex EAV. Below are the steps which I have followed -
From above screenshots we can see time difference is only 1 min. Can you provide information about it. Thanks |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
When the MariaDB is try to cast the entitys_ids from string to integer is to slow,
Check: #27129
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
In this PR, when you try to reindex EAV, the query can be vary from:
Questions or comments
Contribution checklist (*)
Resolved issues: