Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch jquery scroll passive for mobile scrolling performance #35613

Draft
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 13, 2022

Description (*)

improve your page's scroll performance
wheel -> passive true cause listener can't block page rendering while the user is scrolling
non wheel (mobile) -> passive false

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#parameters

actually jquery core should fix this at the codebase. In the meantime we can delivery this patch at first place then replace/remove it later when upgrade jquery version to higher version contain fixes.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Does not use passive listeners to improve scrolling performance #34158

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2022

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jun 13, 2022
@engcom-Hotel engcom-Hotel added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jun 14, 2022
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@mrtuvn does it really improves performance? Can we measure it?

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn added the Area: Perf/Frontend All tickets related with improving frontend performance. label Mar 16, 2023
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 16, 2023

Seem this is known issue from the core jquery too.
See here jquery/jquery#2871
Seems like this issue isn't trivial to resolve or is it?

@mrtuvn mrtuvn marked this pull request as draft March 17, 2023 09:58
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 3, 2023

Note this is patch for magento side. But imho it's should be fix from jquery core then reflect back to magento. So i keep this on as draft state. Feel free to use this patch but note this should be test carefully when bring it to production evironment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Perf/Frontend All tickets related with improving frontend performance. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: on hold
Projects
Development

Successfully merging this pull request may close these issues.

Does not use passive listeners to improve scrolling performance
3 participants