Shipping Estimation: Prevent Quote Double Saving

[pykettk]

Description (*)

• Removes a seemingly superfluous additional saving of the quote when estimating shipping
  • The Magento\Checkout\Model\Cart::save() function also saves the quote in the same manner
• Only sets collectShippingRates once
  • The Magento\Checkout\Model\Cart::save() function also sets this

Manual testing scenarios (*)

1. Install sample data
2. Add a product to the cart
3. Proceed to the cart page
4. Estimate shipping using valid address data
5. Ensure the available shipping methods are displayed
6. Ensure the selecting of a shipping method updates cart totals correctly

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Shipping Estimation: Prevent Quote Double Saving #36648: Shipping Estimation: Prevent Quote Double Saving

[m2-assistant]

Hi @pykettk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[pykettk]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento give me test instance

[magento-deployment-service]

Hi @pykettk. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @pykettk, here is your Magento Instance: https://7bc6b6cd1c80b4cb7a45ad4bf3a735b2.instances.magento-community.engineering
Admin access: https://7bc6b6cd1c80b4cb7a45ad4bf3a735b2.instances.magento-community.engineering/admin_3514
Login: 7c419573
Password: 795139c63847

[pykettk]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @pykettk. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @pykettk, here is your Magento Instance: https://2da598e733dcd48819a6848931afe176.instances.magento-community.engineering
Admin access: https://2da598e733dcd48819a6848931afe176.instances.magento-community.engineering/admin_50a5
Login: 9b20320b
Password: 5e48f631a568

[pykettk]

Personal manual testing using the above instances presents the same (existing) behaviour.

2.4 Develop Instance

PR Test Instance

[pykettk]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

Failing tests appear unrelated.

[pykettk]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[pykettk]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Delta]

@magento create issue