Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note to Explain Search Weight Values #35738

Merged
merged 5 commits into from Aug 31, 2022
Merged

Add Note to Explain Search Weight Values #35738

merged 5 commits into from Aug 31, 2022

Conversation

pykettk
Copy link
Member

@pykettk pykettk commented Jul 7, 2022

Description (*)

Adds a note beneath the Search Weight attribute's Storefront Properties input to explain what the values mean.

Manual testing scenarios (*)

  1. Log into the admin
  2. Navigate to Stores -> Attributes -> Product
  3. Select any attribute from the grid
  4. Open the Storefront Properties options on the left hand side
  5. Ensure Use in Search is enabled
  6. Observe the note is present beneath the Search Weight option
  7. The note should read: 10 is the highest priority/heaviest weighting.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add Note to Explain Search Weight Values #36646: Add Note to Explain Search Weight Values

@m2-assistant
Copy link

m2-assistant bot commented Jul 7, 2022

Hi @pykettk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Jul 7, 2022
@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

@magento give me test instance

@magento-deployment-service
Copy link

Hi @pykettk. Thank you for your request. I'm working on Magento instance for you.

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @pykettk. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@magento-deployment-service
Copy link

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

Manual Testing

Test Instance

image

2.4 Develop Instance

image

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Jul 7, 2022

Failing functional tests are unrelated to changes in this PR.

@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jul 12, 2022
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Jul 12, 2022
@pykettk
Copy link
Member Author

pykettk commented Jul 21, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member Author

pykettk commented Aug 1, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 6f79bd8 into magento:2.4-develop Aug 31, 2022
@pykettk pykettk deleted the search-weight-admin-note branch August 31, 2022 07:41
@ihor-sviziev ihor-sviziev moved this from Pending Review to Recently Merged in High Priority Pull Requests Dashboard Aug 31, 2022
@engcom-Delta
Copy link
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add Note to Explain Search Weight Values
5 participants