-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow items to be shipped with a qty > 0 and < 1 #35972
Conversation
…ked for <= 0, so anything > 0 and < 1 would be (incorrectly) cast to a 0. If this check fails, the item is not added to the shipment. By casting to a float, the validation is passed correctly and you can now ship items with a qty between 0 and 1.
Hi @ArronKing. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Copy of #35963 |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests EE, Static Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Static Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Integration Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Since the PR branch is blocked(Read only), Created a new PR with the current changes along with fix for the bulid failures.Hence closing this PR Thank you. |
Yes shipment can be made with qty lower than 1, but order will not change to "completed". So it stays "Processing" while shipment had been made... |
Description (*)
Cast the qty to a float, rather than an int. The casted value is checked for <= 0, so anything > 0 and < 1 would be (incorrectly) cast to a 0. If this check fails, the item is not added to the shipment. By casting to a float, the validation is passed correctly and you can now ship items with a qty between 0 and 1.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)