-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magento Customer optional prefix/suffix displays random zeros #36003
Magento Customer optional prefix/suffix displays random zeros #36003
Conversation
Hi @lbajsarowicz. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
I have the feeling this might fix: #32177, could that be? |
Hey @hostep - Yes, it is the fix for the mentioned issue. |
So to confirm, in file vendor/magento/module-customer/Model/Options.php Changing line 110 fixes the prefix issue I reported 18 months ago? |
You can just apply Composer Patch: https://patch-diff.githubusercontent.com/raw/magento/magento2/pull/36003.diff More info: https://experienceleague.adobe.com/docs/commerce-operations/upgrade-guide/patches/apply.html You are welcome. |
Looks like Adobe decided to approve another fix: #35060 |
Description (*)
The issue is caused by Magento using the POST value as a prefix/suffix. As the keys are numbers, not the actual numbers, you end up with random numbers used as suffix / prefix.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)