Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in graphql query #36118

Conversation

DmitrySamushchenko
Copy link
Contributor

@DmitrySamushchenko DmitrySamushchenko commented Sep 8, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Fatal when using GraphQl query #36117

Manual testing scenarios (*)

Run this GraphQl query:

query {
  products(filter: {category_id: {eq: "2"}}, sort: {price:ASC}, currentPage: 1) {
    items {
      ...productAttributesForListing
      ... on ConfigurableProduct {
        variants {
          __typename
        }
      }
    }
  }
}

fragment productAttributesForListing on ProductInterface {
  categories {
    breadcrumbs {
      category_name
    }
  }
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 8, 2022

Hi @DmitrySamushchenko. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Den4ik
Copy link
Contributor

Den4ik commented Sep 13, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik self-requested a review September 13, 2022 00:02
@Den4ik Den4ik self-assigned this Sep 13, 2022
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Sep 13, 2022
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved due to low risk and transparent changes.

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 13, 2022
@m2-community-project m2-community-project bot moved this from Ready for Testing to Review in Progress in Pull Requests Dashboard Sep 13, 2022
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 13, 2022
@m2-community-project m2-community-project bot moved this from Ready for Testing to Review in Progress in Pull Requests Dashboard Sep 13, 2022
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 13, 2022
@sdzhepa sdzhepa added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Sep 15, 2022
@m2-community-project m2-community-project bot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Oct 6, 2022
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rimple-saini
Copy link
Contributor

@DmitrySamushchenko Thank you fixing this issue.

It will be taken care into one of the Internal JIRA ticket. Once Internal PR will get merged, we will notify.

Thank you!

CC @Den4ik

@engcom-Delta engcom-Delta removed their assignment Oct 14, 2022
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Oct 14, 2022
@m2-community-project m2-community-project bot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Oct 14, 2022
@m2-community-project m2-community-project bot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Oct 14, 2022
@engcom-Lima
Copy link
Contributor

Looking like bot had moved this ticket to ready for testing . Hence, moving back to extended testing.

@ishakhsuvarov ishakhsuvarov added this to Pending Review in Pull Requests Dashboard Dec 8, 2022
@ishakhsuvarov ishakhsuvarov moved this from Pending Review to Extended Testing (optional) in Pull Requests Dashboard Dec 8, 2022
@ishakhsuvarov ishakhsuvarov removed this from Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 8, 2022
@engcom-Hotel
Copy link
Contributor

The related issue has already been fixed and merged with the development branch. Please refer the below comment for more information:

#36117 (comment)

Hence closing this PR.

thanks

@m2-community-project m2-community-project bot removed this from Extended Testing (optional) in Pull Requests Dashboard Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogGraphQl Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Risk: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal when using GraphQl query
10 participants