Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order Item Repository saving and deleting items on the null key in registry #36172

Open
wants to merge 9 commits into
base: 2.4-develop
Choose a base branch
from
Open

Order Item Repository saving and deleting items on the null key in registry #36172

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7734fce
save entity in registry with item_id as key instead of null entity_id
Apr 5, 2022
dc41502
delete entity from registry based on item_id instead of null entity_id
Apr 5, 2022
1ab43ca
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Sep 21, 2022
10ea851
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Oct 25, 2022
eb44ac5
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Nov 13, 2022
ddffeb1
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Nov 29, 2022
ffd54fe
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Jan 1, 2023
8bcf505
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Jan 17, 2023
c23f347
Merge branch '2.4-develop' into bugfix/orderitem-repository-saving-de…
ioiste Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Sales/Model/Order/ItemRepository.php
View file
Open in desktop
Expand Up @@ -142,7 +142,7 @@ public function getList(SearchCriteriaInterface $searchCriteria)
public function delete(OrderItemInterface $entity)
{
$this->metadata->getMapper()->delete($entity);
unset($this->registry[$entity->getEntityId()]);
unset($this->registry[$entity->getItemId()]);
return true;
}

Expand Down Expand Up @@ -171,8 +171,8 @@ public function save(OrderItemInterface $entity)
}

$this->metadata->getMapper()->save($entity);
$this->registry[$entity->getEntityId()] = $entity;
return $this->registry[$entity->getEntityId()];
$this->registry[$entity->getItemId()] = $entity;
return $this->registry[$entity->getItemId()];
}

/**
Expand Down