Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 36272: fix coupon report in admin #36311

Closed
wants to merge 1 commit into from

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Oct 17, 2022

Description (*)

Update logic get data of multi-select field.
Fix same issue for Order Status in Admin-> Reports > Sales > Shipping

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes When trying to use certain multi-selects within the Magento admin for coupon report, they don't always work as intended. #36272

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2022

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 17, 2022
@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 17, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 17, 2022

@magento run Unit Tests, Integration Tests, Functional Tests EE, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Priority: P0 This generally occurs in cases when the entire functionality is blocked. label Oct 19, 2022
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Nov 27, 2022
@ishakhsuvarov ishakhsuvarov removed this from Review in Progress in High Priority Pull Requests Dashboard Dec 8, 2022
@ishakhsuvarov ishakhsuvarov added this to Pending Review in Pull Requests Dashboard Dec 8, 2022
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerdz,
It looks like the issue was already fixed in 74e6857.
Could you please confirm that?

@glo30253
Copy link

glo30253 commented Feb 13, 2023

Hi rogerdz,
Thankyou for your contribution.
I checked the issue on 2.4-develop and issue is not reproducible.
Steps followed:
1 Created 2-3 more cart rules and place an order for each.
2 Went to Admin-> Reports > Sales > Coupons
3 Applied filter as below
Date Used = Order Created
Period = Day
From = Any previous date
To = Today
Order Status = Any
Empty Rows = No
Cart Price Rule = Specified and selected multi coupons created.
4 Selected "Show Report"
And it display results for selected cart rule and preserve value which was selected in the multi-select box.

Screenshot 2023-02-13 at 7 32 59 PM

Screenshot 2023-02-13 at 7 31 23 PM

Hence issue is no more reproducible in 2.4-develop and we are closing this PR.

@engcom-Charlie
Copy link
Contributor

As per above comments closing this PR

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P0 This generally occurs in cases when the entire functionality is blocked. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
5 participants