Fixed table difference insert during price reindex

[ilnytskyi]

Description (*)

Problem appears when dimensions are not used.
catalog_product_index_price is now incompatible with catalog_product_index_price_tmp as new ID columnt added
https://devdocs.magento.com/guides/v2.4/release-notes/backward-incompatible-changes/reference.html
so method works incorrectly as final query contains additional column

\Magento\Catalog\Model\Indexer\Product\Price\AbstractAction::_syncData

We faced this issue while running graphql tests when indexers is set - update on save
The issue might be skipped in fixtures but when tests are placing the order - it triggers reindex that blocks order placing.

In query logs we may see how temp table is created

## 140 ## QUERY
SQL: CREATE TEMPORARY TABLE IF NOT EXISTS `catalog_product_index_price_temp` LIKE `catalog_product_index_price_tmp`
AFF: 0
TIME: 0.0008

Related Pull Requests

Fixed Issues (if relevant)

cannot reindex price

Magento\Framework\Exception\LocalizedException: SQLSTATE[21S01]: Insert value list does not match column list: 1136 Column count doesn't match value count at row 1, query was: INSERT INTO `catalog_product_index_price` SELECT `ip_tmp`.* FROM `catalog_product_index_price_temp` AS `ip_tmp` ON DUPLICATE KEY UPDATE `tax_class_id` = VALUES(`tax_class_id`), `price` = VALUES(`price`), `final_price` = VALUES(`final_price`), `min_price` = VALUES(`min_price`), `max_price` = VALUES(`max_price`), `tier_price` = VALUES(`tier_price`) in /home/www/magento/vendor/magento/module-catalog/Model/Indexer/Product/Price/Action/Row.php on line 32

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

0. Set indexer update on save
1. Create product on 2.4.5 installation
2. Create custom script to reindex
3. RUN Magento\Catalog\Model\Indexer\Product\Price::executeRow
4. See error.
5. Apply patch from this PR
6. retry reindex - no error

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves catalog_product_price index getting stuck #36471: Fixed table difference insert during price reindex

[m2-assistant]

Hi @ilnytskyi. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ilnytskyi]

@kandy could you take a look?
As I see in logs incompatibility beetween catalog_product_index_price_tmp and catalog_product_index_price was introduced in your commit.

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run Functional Tests B2B

[Den4ik]

✅ Approved
Failed B2B test is not related to PR

[engcom-Delta]

@magento create issue

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

@ilnytskyi @Den4ik @kandy @michaellehmkuhl
Thanks for the collaboration & contribution!

✔️ QA Passed
Fixed table difference insert during price reindex

Manual Scenario Steps

1. Put the module in app\code folder.
2. Run bin/magento setup:upgrade command
3. Create a new product of the new Product type created by the above module.
4. Indexer should be on "Update by Schedule"
5. Run the below command to trigger the error:
6. n98-magerun2 sys:cron:run indexer_update_all_views

Before: ✖️

After: ✔️

[engcom-Echo]

Functional Test B2B failures are different on last two run
Run1

Run2

Hence moving to Merge In Progress.

[engcom-Echo]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[maaarghk]

why did this not make it into 2.4.6 : (

[EclipseEternal]

Hi, do we have an idea when will this be available or in which version?

[TuVanDev]

@EclipseEternal This pull request has been merged into Magento 2.4.7-beta1 and 2.4.7-beta2. As a result, when Magento 2.4.7 is released next April, it will include version 2.4.7.
To identify the branches where the commits from this pull request were merged, you can refer to the git commit. For example, d53d0f9
For more details on future release information, refer to the release schedule https://experienceleague.adobe.com/docs/commerce-operations/release/planning/schedule.html?lang=en

[EclipseEternal]

Hi, thank you for your tips, we will patch then waiting for the 2.4.7.