-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed table difference insert during price reindex #36370
Fixed table difference insert during price reindex #36370
Conversation
Hi @ilnytskyi. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
|
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests EE, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved
Failed B2B test is not related to PR
@magento create issue |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@ilnytskyi @Den4ik @kandy @michaellehmkuhl ✔️ QA Passed Manual Scenario Steps
|
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
why did this not make it into 2.4.6 : ( |
Hi, do we have an idea when will this be available or in which version? |
@EclipseEternal This pull request has been merged into Magento 2.4.7-beta1 and 2.4.7-beta2. As a result, when Magento 2.4.7 is released next April, it will include version 2.4.7. |
Hi, thank you for your tips, we will patch then waiting for the 2.4.7. |
Description (*)
Problem appears when dimensions are not used.
catalog_product_index_price
is now incompatible withcatalog_product_index_price_tmp
as new ID columnt addedhttps://devdocs.magento.com/guides/v2.4/release-notes/backward-incompatible-changes/reference.html
so method works incorrectly as final query contains additional column
We faced this issue while running graphql tests when indexers is set -
update on save
The issue might be skipped in fixtures but when tests are placing the order - it triggers reindex that blocks order placing.
In query logs we may see how temp table is created
Related Pull Requests
Fixed Issues (if relevant)
cannot reindex price
Manual testing scenarios (*)
Magento\Catalog\Model\Indexer\Product\Price::executeRow
Questions or comments
Contribution checklist (*)
Resolved issues: