Fixed issue Billing & Shipping address the same checkbox is empty

[rostilos]

Description (*)

Related Pull Requests

magento/inventory#3383

Fixed Issues (if relevant)

1. Fixes 'Billing & Shipping address the same' checkbox is empty #33725

Manual testing scenarios (*)

1. Add some product to cart
2. Go to checkout
3. Fill shipping address by Chrome autocomplete
4. Click 'Next' to go to next step BEFORE shipping methods block is reloaded (recalculated)
5. 'My billing and shipping address are the same' checkbox is checked by default

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rostilos. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[rostilos]

@magento run all tests

[engcom-Charlie]

Hi @rostilos,

Thank you for your contribution!

I will look into this failure.

Thank you!

[engcom-Charlie]

Removed the unwanted file change from the PR to fix the AdminCreateCustomerSegmentConditionCombinationTest .xml Functional B2B failure.

Thank you!

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Charlie]

AdminCreateCustomerSegmentConditionCombinationTest .xml failure is fix now.

Rerunning the rest of the build.

[engcom-Charlie]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rostilos]

@engcom-Charlie It seems to me that the errors in the tests are not related to the edits in the PR ( Almost all errors are related to the functionality in the admin panel or related to the problem that some products in the build out of the stock, and are not related to edits from the PR, as the edits implied only visual storefront functionality on checkout/cart pages).
Could you confirm this?

[engcom-Charlie]

@engcom-Charlie It seems to me that the errors in the tests are not related to the edits in the PR ( Almost all errors are related to the functionality in the admin panel or related to the problem that some products in the build out of the stock, and are not related to edits from the PR, as the edits implied only visual storefront functionality on checkout/cart pages). Could you confirm this?

Hi @rostilos,

In AdminCreateCustomerSegmentConditionCombinationTest.xml test, when control goes to checkout/cart page, because of below changes, made in f182aa1 commit the test is failing as Unable to locate element: {"method":"css selector","selector":"#checkout-shipping-method-load}

app/code/Magento/Checkout/Test/Mftf/ActionGroup/CheckoutSelectFlatRateShippingMethodActionGroup.xml

Thank you!

[Den4ik]

I can confirm that failed tests looks not related to the changes

[Den4ik]

AdminCreateCustomerSegmentConditionCombinationTest
@engcom-Charlie Where do you see failed AdminCreateCustomerSegmentConditionCombinationTest?
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36463/4cd43f05ba355cac001dc35f6eed4dc9/Functional/allure-report-ce/index.html#suites
I don't see this test fail there

[engcom-Charlie]

AdminCreateCustomerSegmentConditionCombinationTest
@engcom-Charlie Where do you see failed AdminCreateCustomerSegmentConditionCombinationTest?
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36463/4cd43f05ba355cac001dc35f6eed4dc9/Functional/allure-report-ce/index.html#suites
I don't see this test fail there

I was explaining about this comment for 3070776 commit @Den4ik.

Remaining failures of Functional CE, B2B and EE are not part of this PR and not failing because of this PR changes. In recent 2 builds the failures are different.

Functional CE Run 1:

Run2:

Functional EE: Run 1

Run 2:

Functional B2B: Run 1:

Run 2:

Hence moving it to Merge in Progress now.

Thank you!

[engcom-Charlie]

@magento run Functional Tests B2B,Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[rostilos]

It seems to me that the failed B2B tests are not related to PR, can any of the reviewers confirm this?

[rostilos]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.