Internal server error on Category graphQl query for redirect code field

[Vasudev-22]

Description (*)

1. redirect_code filed will not accept as null ,because in graphQl the field was set a mandatory with integer value.
2. If redirect_code is null in category graphQl, then it will return as Zero.
   redirect_code Int!
   Contains 0 when there is no redirect error. A value of 301 indicates the URL of the requested resource has been changed permanently, while a value of 302 indicates a temporary redirect.

Related Pull Requests

Fixes for #36675

Fixed Issues (if relevant)

1. Fixes Internal server error on Category graphql query #36675

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Vasudev-22. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Vasudev-22]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[swnsma]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[swnsma]

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[swnsma]

Hi @Vasudev-22,

Thank you for your contribution!
Please check my suggestion.

According to definition of done, changes should be covered by auto-tests.
I may suggest changes in \Magento\GraphQl\CatalogUrlRewrite\RouteTest.

[Vasudev-22]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[swnsma]

Hi @Vasudev-22,

Thank you for your changes!

According to definition of done, changes should be covered by auto-tests.
I may suggest changes in \Magento\GraphQl\CatalogUrlRewrite\RouteTest.

[engcom-Delta]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Delta]

@Vasudev-22 @swnsma

Thank you for your contribution!

The functional test failures in B2B and CE are different from the last two run.
B2B : run1

run2

CE : run1

run2

Hence, moving this PR to Ready for Testing

Thanks.

[engcom-Lima]

@magento run Functional Tests B2B, Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop with Sample data.

Manual testing scenario:
-> Run below graphQL query and check the response:

{
	categories(filters: {}, pageSize: 1, currentPage: 2) {
		total_count
		items {
			available_sort_by
			uid
			level
			name
			path
			children_count
			canonical_url
			children_count
			custom_layout_update_file
			default_sort_by
			description
			display_mode
			filter_price_range
			image
			include_in_menu
			is_anchor
			landing_page
			level
			meta_description
			meta_keywords
			meta_title
			name
			path
			path_in_store
			position
			product_count
			redirect_code
			relative_url
			type
			uid
			url_key
			url_path
			url_suffix
			children {
				uid
				level
				name
				path
				children_count
				children {
					uid
					level
					name
					path
				}
			}
		}
		page_info {
			current_page
			page_size
			total_pages
		}
	}
}

Before: ✖️ Getting internal server error in the response.

After: ✔️ Now it is working fine.

Additionally tested:

• Tested without sample data.
• Removed products and verified the error coming or not in the response.
• Removed category and verified the error coming or not in the response.

No need of additional test cases is required as part of regression.

As per above comment failed testcases not related to the PR. Hence, moving this PR to Merge in progress.

[engcom-Charlie]

It seems bot moved this PR from Merge in Progress to Ready for Testing hence moving it back.