Changes of GR(Greece) PostCode Pattern

[Vasudev-22]

Description (*)

Change Pattern for GR PostCodes

Related Pull Requests

Fixes for #36676

Fixed Issues (if relevant)

1. Fixes Zip Code for Greece should not expect space #36676 Greece should allow zipcode without space

Manual testing scenarios (*)

1. Buy Product
2. Go Checkout
3. Select Greece Country
4. Put PostCode: 12345
   
   

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Vasudev-22. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Vasudev-22]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[hostep]

@ishakhsuvarov: will this give issues for customers in Magento that already have stored addresses with zip codes in the old format if they want to check out again? Maybe this needs to be tested if it hasn't been yet, before this gets approved?

It might be safer to allow both the old format (with space) and the new format (without space), so a regex like: ^[0-9]{3}\s?[0-9]{2}$

Just my 2 cents, maybe my remark makes no sense...

[Vasudev-22]

@ishakhsuvarov: will this give issues for customers in Magento that already have stored addresses with zip codes in the old format if they want to check out again? Maybe this needs to be tested if it hasn't been yet, before this gets approved?

It might be safer to allow both the old format (with space) and the new format (without space), so a regex like: ^[0-9]{3}\s?[0-9]{2}$

Just my 2 cents, maybe my remark makes no sense...

@hostep ,
Even the old customer need to show this warning/error message to update correctly.

[hostep]

Even the old customer need to show this warning/error message to update correctly.

Why?
It might be annoying for existing customers if they see warnings even if their old orders worked perfectly fine with their old postcode.

[Vasudev-22]

Even the old customer need to show this warning/error message to update correctly.

Why? It might be annoying for existing customers if they see warnings even if their old orders worked perfectly fine with their old postcode.

Before it shown the postal-code in space format, that was an core issue and this is in wrong format of that country specific pin-code, so we correcting in our system, that's why we need to show them as warning to update it correctly as per your country pin-code.

[hostep]

I still would like to hear a second opinion on this, @ishakhsuvarov what do you think, or can you drag in somebody who knows a lot about this?

[cptX]

Hi, I have created the issue #36676.
As a Greek, in my whole life I never say the PC written with a space. @hostep In my opinion we should not allow both with space and without to have a better and more consistent format across all customers.

[hostep]

Sure, I believe you guys, I was just concerned about causing potential problems/annoyances to existing customers of shops if they have entered and stored their postal code in the old (wrong) format.

But it seems like nobody agrees here with my remarks, so feel free to continue with this PR 🙂

[engcom-Lima]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Lima]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

• Buy Product
• Go Checkout
• Select Greece Country
• Put PostCode: 12345

Before: ✖️ Zipcode gives warning

After: ✔️ Now working fine

Builds are failed. Hence, moving this PR to Extended Testing.

[engcom-Lima]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Lima]

It looks like the bot had moved this PR from **Extended testing ** to Ready for testing. Hence, again moving this PR to
Extended testing

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.