Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken fotorama image slider on mobile Fixes #37232 #37355

Merged
merged 1 commit into from
May 11, 2023

Conversation

vseager
Copy link
Contributor

@vseager vseager commented Apr 10, 2023

Description (*)

Fixes broken product image slider on mobile devices (issue #37232)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Cannot slide images in product page in mobile in 2.4.6 only! #37232

Manual testing scenarios (*)

  1. Tested product image slider on mobile
  2. Tested product image slider on desktop

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2023

Hi @vseager. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 10, 2023
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 10, 2023
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vseager,
We already have PR #37234 that fixes the same issue.
Could you please explain why you think this solution is better?

@m2-community-project m2-community-project bot moved this from Pending Review to Changes Requested in Pull Requests Dashboard Apr 10, 2023
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit cee8d63 into magento:2.4-develop May 11, 2023
1 check failed
@engcom-Charlie engcom-Charlie moved this from Changes Requested to Recently Merged in Pull Requests Dashboard Jun 2, 2023
@engcom-Charlie engcom-Charlie self-assigned this Jun 2, 2023
@engcom-Charlie
Copy link
Contributor

As the PR got merged, moved it to Recently Merge.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: needs update
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Cannot slide images in product page in mobile in 2.4.6 only!
4 participants