#37509 | Verification added to redis preloading to prevent array_comb…

[LeanderFS]

…ine receiving false as second argument

Description (*)

This change will ensure the preloading code will continue to run even when exec() returns false.

Fixed Issues (if relevant)

1. Fixes Redis preloading fails when exec() returns false #37509

Manual testing scenarios (*)

See #37509

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @LeanderFS. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Hello @LeanderFS,

Please look into my review comments. Also can you please cover this change with some automated tests like unit tests by mocking the object?

Thanks

[engcom-Hotel]

I suggest you check here if the redisResponse is an array, then only do the further action otherwise set an empty array.

[engcom-Echo]

$redis->exec() return array so not required.

[engcom-Hotel]

Here the method signature for exec() in Credis_Client class tells us that it returns array only but internally as per the documentation of credis, for better performance wraps the phpredis library when available. but when checking the implementation in phpredis, exec() can return Redis|array|false also. Thats why I asked to add a check here if the return value is array then only move further.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Failed Functional tests are different in 2 consecutive runs:

Functional Tests CE:

Functional Tests EE:

Failed tests seem flaky to me, hence moving further with this PR.

Thanks

[engcom-Hotel]

✔️ QA Passed

Preconditions

• Magento 2.x
• Redis 6.0.10 (Probably every version of Redis)
• phpredis

Manual Testing Scenario

1. Install Magento 2 as normal
2. Enable Redis in env.php under cache->frontend->default
3. Make sure to set backend option to Magento\\Framework\\Cache\\Backend\\Redis
4. Set id_prefix and preload_keys
5. Run bin/magento cache:clean

Actual Result: ✔️

After: ✔️

Before: ✖️

Tested all the manual scenarios, no impact on regression testing.

Failed tests seem flaky to me hence moving this PR to merge in progress.

Thanks

[engcom-Hotel]

@magento run Functional Tests EE, Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Failed tests are flaky, hence moved PR in Merge in progress. Please have a look at the below screenshot for reference:

Thanks

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.