-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#38684 Fix S3 incorrect option name #38685
#38684 Fix S3 incorrect option name #38685
Conversation
Hi @Nuranto. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
if (!empty($config['path_style'])) { | ||
$config['use_path_style_endpoint'] = boolval($config['path_style']); | ||
if (!empty($config['path-style'])) { | ||
$config['use_path_style_endpoint'] = boolval($config['path-style']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great to use this change to replace the function boolval by a direct cast (bool) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right !
@magento run all tests |
@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B, Static Tests |
Hello @Nuranto, We are closing this PR due to the original issue is not reproducible at our end. Please refer to the below comment for more information: Feel free to provide some more information on issue reproduction, we will be happy to reopen this PR. Thanks |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)