Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-rendering already loaded grid for Product Options (SwiftOtter's SOP-348) #38734

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented May 16, 2024

Description (*)

In the Product Edit Page, when you open the “Customizable Options” bar, all the Product Options are visible. Suddenly, the loader icon pops up and all the options are rendered again.

The bug was introduced in 2022, and is affecting Product Edit page especiall with a big subsets of options.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. When I open “Customizable Options” section on Edit Product page, and the values of the options are rendered, the loader doesn’t appear afterwards, and the content is not re-rendered.
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Avoid re-rendering already loaded grid for Product Options (SwiftOtter's SOP-348) #38741: Avoid re-rendering already loaded grid for Product Options (SwiftOtter's SOP-348)

Copy link

m2-assistant bot commented May 16, 2024

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard May 21, 2024
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 21, 2024
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label May 21, 2024
@m2-community-project m2-community-project bot added this to Pending Review in Community Dashboard May 21, 2024
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard May 21, 2024
@engcom-Hotel engcom-Hotel self-requested a review June 7, 2024 12:11
@engcom-Hotel
Copy link
Contributor

Hello @lbajsarowicz,

According to this comment #38741 (comment), we are unable to reproduce the original issue and you will going to provide us some more details on issue reproduction #38741 (comment).

We are still waiting for your reply on the same so that we can move further with this PR. Meanwhile, we are moving this PR to the On Hold bucket.

Let us know whenever you are ready with this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community
Projects
Development

Successfully merging this pull request may close these issues.

[Issue] Avoid re-rendering already loaded grid for Product Options (SwiftOtter's SOP-348)
3 participants