Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #4844

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Fix typo #4844

merged 1 commit into from
Mar 26, 2017

Conversation

orlangur
Copy link
Contributor

@orlangur orlangur commented Jun 3, 2016 •
edited by vrann

No description provided.

@vkublytskyi vkublytskyi added the MX label Jun 3, 2016
@evgk
Copy link
Member

evgk commented Jun 3, 2016

According to this link:
https://www.quora.com/Which-is-the-correct-grammar-usage-a-unique-or-an-unique

It should be "a unique", actually

@orlangur
Copy link
Contributor Author

orlangur commented Jun 3, 2016

Thanks @evgk,

Use "an" before the words that start from vowels A, E, I, O, U. But that is not the 100% foolproof method.`

I didn't even try to google for it. Will force push a corrected version soon.

@orlangur
Copy link
Contributor Author

orlangur commented Jun 8, 2016

Fixed and rebased against latest mainline.

@orlangur
Copy link
Contributor Author

orlangur commented Jul 4, 2016

Any idea why such a simple change is processed for more than a month already?

@vkorotun vkorotun added Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report bugfix and removed MX Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 3, 2016
@orlangur orlangur mentioned this pull request Mar 8, 2017
Closed
@keradus
Copy link
Contributor

keradus commented Mar 8, 2017

👍 :shipit:

@vrann vrann self-assigned this Mar 25, 2017
@vrann vrann added this to the March 2017 milestone Mar 25, 2017
@magento-team magento-team merged commit 30af634 into magento:develop Mar 26, 2017
magento-team pushed a commit that referenced this pull request Mar 26, 2017
@vrann
MAGETWO-66764: Fix typo #4844
5a1b122
@vrann
Copy link
Contributor

vrann commented Mar 26, 2017

@orlangur thank you, Vlad, merged.

@orlangur orlangur deleted the unigue-unique branch March 27, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vrann vrann

Labels
bugfix Component: Catalog
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@orlangur @evgk @keradus @vrann @magento-team @vkublytskyi @vkorotun