Schedule generation was broken #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajpevers could you please fix travis tests so that we can proceed with acceptance of this PR? |
Only one schedule entry was generated at schedule generation because of this `return;`. fixes magento#4173
|
@okorshenko I've changed the unit test for cron generation so that one or more schedule saves are expected. The remaining failure is a large amount of constructor parameters in |
|
@ajpevers thank you for fixing the tests. Yes, we can accept it with failed static test since this is not the issue caused by your changes. Thank you |
|
@ajpevers thank you for your contribution! |
|
This fix hasn't been applied yet at version 2.1.7. |
|
@adrian-martinez-interactiv4 the fix will be available with upcoming patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one schedule entry was generated at schedule generation because of this
return;.fixes #4173